Bug 208238

Summary: Use WebPageProxy preferences for capture instead of WebProcessPool configuration parameters
Product: WebKit Reporter: youenn fablet <youennf>
Component: WebRTCAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, eric.carlson, simon.fraser, webkit-bug-importer, youennf, ziadrb
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=209155
Attachments:
Description Flags
Patch none

Description youenn fablet 2020-02-26 05:20:43 PST 
Use WebPageProxy preferences for capture instead of WebProcessPool configuration parameters
Comment 1 youenn fablet 2020-02-26 05:28:56 PST 
Created attachment 391741 [details]
Patch
Comment 2 Radar WebKit Bug Importer 2020-02-26 05:40:38 PST 
<rdar://problem/59803140>
Comment 3 WebKit Commit Bot 2020-02-26 07:57:25 PST 
Comment on attachment 391741 [details]
Patch

Clearing flags on attachment: 391741

Committed r257472: <https://trac.webkit.org/changeset/257472>
Comment 4 WebKit Commit Bot 2020-02-26 07:57:26 PST 
All reviewed patches have been landed.  Closing bug.
Comment 5 Z 2020-03-16 15:21:31 PDT 
Not able to run Safari on Catalina (10.15.3)

$ svn info
Path: .
Working Copy Root Path: /Users/user/webkit
URL: https://svn.webkit.org/repository/webkit/trunk
Relative URL: ^/trunk
Repository Root: https://svn.webkit.org/repository/webkit
Repository UUID: 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Revision: 258497
Node Kind: directory
Schedule: normal
Last Changed Author: commit-queue@webkit.org
Last Changed Rev: 258497
Last Changed Date: 2020-03-16 10:27:05 -0500 (Mon, 16 Mar 2020)

Configured as

$ Tools/Scripts/set-webkit-configuration --asan --release

Built as

$ Tools/Scripts/build-webkit

Run

$ Tools/Scripts/run-safari 
Starting SafariForWebKitDevelopment with DYLD_FRAMEWORK_PATH set to point to built WebKit in /Users/user/webkit/WebKitBuild/Release.
dyld: Symbol not found: _WKContextConfigurationSetShouldCaptureAudioInUIProcess
  Referenced from: /System/Library/PrivateFrameworks/Safari.framework/Versions/A/Safari
  Expected in: /Users/user/webkit/WebKitBuild/Release/WebKit.framework/Versions/A/WebKit
 in /System/Library/PrivateFrameworks/Safari.framework/Versions/A/Safari