Bug 208226

Summary: Add Highlight API to features.json
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: HTML EditingAssignee: Megan Gardner <megan_gardner>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, joepeck, simon.fraser, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: Safari Technology Preview   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch for landing none

Description Simon Fraser (smfr) 2020-02-25 17:20:14 PST
Need to add highlight API to WebCore/features.json so it shows up on https://webkit.org/status/
Comment 1 Megan Gardner 2021-08-17 16:43:15 PDT
Created attachment 435728 [details]
Patch
Comment 2 Simon Fraser (smfr) 2021-08-17 19:02:27 PDT
Comment on attachment 435728 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=435728&action=review

> Source/WebCore/features.json:98
> +            "status": "Under Consideration",

Isn't it more like "In Development"?

> Source/WebCore/features.json:104
> +        "description": "Allows content to define the style for pseudo-elements and their ranges."

You could just lift text from the spec and say " A mechanism for styling arbitrary ranges of a document identified by script."
Comment 3 Megan Gardner 2021-08-18 09:45:43 PDT
I tried searching other specs for their description text and I didn't find any that did, or ideas of where to pull from, so I just tried my best. Copying the description is better, though.
Comment 4 Megan Gardner 2021-08-18 09:47:05 PDT
Created attachment 435777 [details]
Patch
Comment 5 Megan Gardner 2021-08-18 09:48:02 PDT
Created attachment 435779 [details]
Patch for landing
Comment 6 EWS 2021-08-18 10:16:17 PDT
Committed r281196 (240640@main): <https://commits.webkit.org/240640@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 435779 [details].
Comment 7 Radar WebKit Bug Importer 2021-08-18 10:17:15 PDT
<rdar://problem/82083022>