| Summary: | Make sure a client cannot cause a whole DOM tree to get leaked by simply holding on to a WKBundleNodeHandle | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Chris Dumez <cdumez> | ||||||
| Component: | WebKit2 | Assignee: | Chris Dumez <cdumez> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | achristensen, beidson, commit-queue, ggaren, jacob_uphoff, rniwa, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Chris Dumez
2020-02-25 14:33:00 PST
Created attachment 391688 [details]
Patch
Comment on attachment 391688 [details] Patch Clearing flags on attachment: 391688 Committed r257389: <https://trac.webkit.org/changeset/257389> All reviewed patches have been landed. Closing bug. Looks like the patch broke api tests in wk1&wk2 https://build.webkit.org/builders/Apple-Catalina-Debug-WK2-Tests/builds/2518/steps/run-api-tests/logs/stdio and also caused 50+ debug tests to crash on wk2 https://build.webkit.org/results/Apple-Catalina-Debug-WK2-Tests/r257467%20(2536)/results.html (In reply to Jacob Uphoff from comment #5) > Looks like the patch broke api tests in wk1&wk2 > https://build.webkit.org/builders/Apple-Catalina-Debug-WK2-Tests/builds/2518/ > steps/run-api-tests/logs/stdio and also caused 50+ debug tests to crash on > wk2 > https://build.webkit.org/results/Apple-Catalina-Debug-WK2-Tests/ > r257467%20(2536)/results.html Oh, easy fix. Will take care of it now. Didn't see your comment till I had already rolled out out.. (In reply to Chris Dumez from comment #6) > (In reply to Jacob Uphoff from comment #5) > > Looks like the patch broke api tests in wk1&wk2 > > https://build.webkit.org/builders/Apple-Catalina-Debug-WK2-Tests/builds/2518/ > > steps/run-api-tests/logs/stdio and also caused 50+ debug tests to crash on > > wk2 > > https://build.webkit.org/results/Apple-Catalina-Debug-WK2-Tests/ > > r257467%20(2536)/results.html > > Oh, easy fix. Will take care of it now. Fix landed in https://trac.webkit.org/changeset/257471/webkit. Reverted r257389 for reason: 257471 Committed r257482: <https://trac.webkit.org/changeset/257482> Created attachment 391764 [details]
Patch
The commit-queue encountered the following flaky tests while processing attachment 391764 [details]: editing/spelling/spellcheck-async-remove-frame.html bug 158401 (authors: morrita@google.com, rniwa@webkit.org, and tony@chromium.org) The commit-queue is continuing to process your patch. Comment on attachment 391764 [details] Patch Clearing flags on attachment: 391764 Committed r257503: <https://trac.webkit.org/changeset/257503> All reviewed patches have been landed. Closing bug. |