| Summary: | TestWebKitAPI.PasteMixedContent.CopyAndPasteWithCustomPasteboardDataOnly should wait until copy operation completes | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Daniel Bates <dbates> | ||||||
| Component: | Tools / Tests | Assignee: | Daniel Bates <dbates> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | webkit-bug-importer, wenson_hsieh | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Local Build | ||||||||
| Hardware: | iPhone / iPad | ||||||||
| OS: | iOS 13 | ||||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=208082 | ||||||||
| Attachments: |
|
||||||||
|
Description
Daniel Bates
2020-02-25 12:48:50 PST
Created attachment 391676 [details]
Patch
We don't need to explicitly wait for select all and paste operations because we implicit wait for them by virtue of sending additional web page messages. Specifically, do not need to wait for select all to complete before executing copy because the WebProcess is guaranteed to receive these requests in order. Similar argument for why there is no need to wait for paste. Comment on attachment 391676 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=391676&action=review Good catch! > Tools/TestWebKitAPI/Tests/WebKitCocoa/PasteMixedContent.mm:-316 > - [source _executeEditCommand:@"copy" argument:nil completion:nil]; Nit - it would probably be simpler to just call -_synchronouslyExecuteEditCommand:argument:. Comment on attachment 391676 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=391676&action=review Thanks for the review. >> Tools/TestWebKitAPI/Tests/WebKitCocoa/PasteMixedContent.mm:-316 >> - [source _executeEditCommand:@"copy" argument:nil completion:nil]; > > Nit - it would probably be simpler to just call -_synchronouslyExecuteEditCommand:argument:. !! I didn't know about this. !! Created attachment 391683 [details]
To land
All reviewed patches have been landed. Closing bug. Committed r257375: <https://trac.webkit.org/changeset/257375> |