| Summary: | Stub Repository needs to call the scm constructor | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Matt Lewis <jlewis3> | ||||||
| Component: | Tools / Tests | Assignee: | Matt Lewis <jlewis3> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | ews-watchlist, glenn, jbedard, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Matt Lewis
2020-02-25 12:46:30 PST
Created attachment 391681 [details]
Patch
This is actually the correct fix I think as when adding stub repository support initially we left out the scm initilization due to trying to override the fact that we don't actually have a SCM. Initiallizing it could have further complications with the filesystems that getr passed around.
Comment on attachment 391681 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=391681&action=review > Tools/Scripts/webkitpy/common/checkout/scm/stub_repository.py:42 > + self.checkout_root = self.find_checkout_root(cwd) Can we call out in a comment why we aren't calling the parent's constructor? That's the sort of mistake I would expect a future contributor to make. Created attachment 391686 [details]
Patch
Added a comment to signify why we aren't calling the parent.
Committed r257378: <https://trac.webkit.org/changeset/257378> |