Bug 208202

Summary: REGRESSION: (r257289) [ macOS ] fast/dom/navigator-detached-no-crash.html is failing
Product: WebKit Reporter: Jacob Uphoff <jacob_uphoff>
Component: DOMAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, megan_gardner, nmouchtaris, webkit-bot-watchers-bugzilla, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description Jacob Uphoff 2020-02-25 09:01:13 PST 
fast/dom/navigator-detached-no-crash.html

This test started to fail on Catalina & Mojave wk2 Debug & GPUProcess after commit r257289

I was able to reproduce this 100% of the time by running the test in iterations with the command 'run-webkit-tests --root debug-257289 fast/dom/navigator-detached-no-crash.html --debug -f --iterations 5' 

This test did not reproduce on commit r257288 and reproduces 100% on r257289.

History:

https://results.webkit.org/?suite=layout-tests&test=fast%2Fdom%2Fnavigator-detached-no-crash.html

Diff:

--- /Volumes/Data/slave/mojave-debug-tests-wk2/build/layout-test-results/fast/dom/navigator-detached-no-crash-expected.txt
+++ /Volumes/Data/slave/mojave-debug-tests-wk2/build/layout-test-results/fast/dom/navigator-detached-no-crash-actual.txt
@@ -6,6 +6,7 @@
 navigator.appCodeName is OK
 navigator.appName is OK
 navigator.appVersion is OK
+navigator.canShare() is OK
 navigator.clipboard is OK
 navigator.cookieEnabled is OK
 navigator.credentials is OK
@@ -36,6 +37,7 @@
 navigator.appCodeName is OK
 navigator.appName is OK
 navigator.appVersion is OK
+navigator.canShare() is OK
 navigator.clipboard is OK
 navigator.cookieEnabled is OK
 navigator.credentials is OK
Comment 1 Radar WebKit Bug Importer 2020-02-25 09:01:36 PST 
<rdar://problem/59766112>
Comment 2 Nikos Mouchtaris 2020-02-25 10:39:23 PST 
Created attachment 391668 [details]
Patch
Comment 3 Megan Gardner 2020-02-25 11:07:30 PST 
Comment on attachment 391668 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=391668&action=review

> LayoutTests/ChangeLog:8
> +        Fixed expected for modified behavior.

This could be a bit more descriptive, what behavior was modified?
Comment 4 Nikos Mouchtaris 2020-02-25 11:13:25 PST 
Created attachment 391673 [details]
Patch
Comment 5 WebKit Commit Bot 2020-02-25 12:14:31 PST 
Comment on attachment 391673 [details]
Patch

Clearing flags on attachment: 391673

Committed r257369: <https://trac.webkit.org/changeset/257369>
Comment 6 WebKit Commit Bot 2020-02-25 12:14:32 PST 
All reviewed patches have been landed.  Closing bug.