| Summary: | ASSERTION FAILED: Completion handler should always be called on inspector/dom-debugger/attribute-modified-style.html | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Jason Lawrence <Lawrence.j> | ||||||
| Component: | Service Workers | Assignee: | youenn fablet <youennf> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | cdumez, commit-queue, webkit-bot-watchers-bugzilla, webkit-bug-importer, youennf | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Mac | ||||||||
| OS: | macOS 10.14 | ||||||||
| Attachments: |
|
||||||||
|
Description
Jason Lawrence
2020-02-24 16:34:32 PST
I have marked this test as crashing while this issue is investigated. https://trac.webkit.org/changeset/257282/webkit stderr: ASSERTION FAILED: Completion handler should always be called !m_function /Volumes/Data/slave/mojave-debug/build/WebKitBuild/Debug/usr/local/include/wtf/CompletionHandler.h(53) : WTF::CompletionHandler<void (std::experimental::fundamentals_v3::expected<bool, WebCore::ExceptionData> &&)>::~CompletionHandler() 1 0x129b6d9f9 WTFCrash 2 0x103321ee3 WTF::CompletionHandler<void (std::experimental::fundamentals_v3::expected<bool, WebCore::ExceptionData>&&)>::~CompletionHandler() 3 0x103320ba5 WTF::CompletionHandler<void (std::experimental::fundamentals_v3::expected<bool, WebCore::ExceptionData>&&)>::~CompletionHandler() 4 0x103914e59 WTF::KeyValuePair<WTF::ObjectIdentifier<WebCore::ServiceWorkerJobIdentifierType>, WTF::CompletionHandler<void (std::experimental::fundamentals_v3::expected<bool, WebCore::ExceptionData>&&)> >::~KeyValuePair() 5 0x103914da5 WTF::KeyValuePair<WTF::ObjectIdentifier<WebCore::ServiceWorkerJobIdentifierType>, WTF::CompletionHandler<void (std::experimental::fundamentals_v3::expected<bool, WebCore::ExceptionData>&&)> >::~KeyValuePair() 6 0x103914d11 WTF::HashTable<WTF::ObjectIdentifier<WebCore::ServiceWorkerJobIdentifierType>, WTF::KeyValuePair<WTF::ObjectIdentifier<WebCore::ServiceWorkerJobIdentifierType>, WTF::CompletionHandler<void (std::experimental::fundamentals_v3::expected<bool, WebCore::ExceptionData>&&)> >, WTF::KeyValuePairKeyExtractor<WTF::KeyValuePair<WTF::ObjectIdentifier<WebCore::ServiceWorkerJobIdentifierType>, WTF::CompletionHandler<void (std::experimental::fundamentals_v3::expected<bool, WebCore::ExceptionData>&&)> > >, WTF::ObjectIdentifierHash<WebCore::ServiceWorkerJobIdentifierType>, WTF::HashMap<WTF::ObjectIdentifier<WebCore::ServiceWorkerJobIdentifierType>, WTF::CompletionHandler<void (std::experimental::fundamentals_v3::expected<bool, WebCore::ExceptionData>&&)>, WTF::ObjectIdentifierHash<WebCore::ServiceWorkerJobIdentifierType>, WTF::HashTraits<WTF::ObjectIdentifier<WebCore::ServiceWorkerJobIdentifierType> >, WTF::HashTraits<WTF::CompletionHandler<void (std::experimental::fundamentals_v3::expected<bool, WebCore::ExceptionData>&&)> > >::KeyValuePairTraits, WTF::HashTraits<WTF::ObjectIdentifier<WebCore::ServiceWorkerJobIdentifierType> > >::deallocateTable(WTF::KeyValuePair<WTF::ObjectIdentifier<WebCore::ServiceWorkerJobIdentifierType>, WTF::CompletionHandler<void (std::experimental::fundamentals_v3::expected<bool, WebCore::ExceptionData>&&)> >*) This shows up as a recent regression (a week ago) on this test, however it's clearly a culprit of some SW test. So the crash may have just moved. http://trac.webkit.org/r256900 doesn't look entirely unrelated though... I was able to reproduce this issue with r257181 by running the command below. run-webkit—tests inspector/dom-debugger/attribute-modified-style.html --iterations 4000 --exit-after-n-failures 5 --force --platform mac-mojave --debug -g Output: [1052/4000] inspector/dom-debugger/attribute-modified-style.html failed unexpectedly (text diff) Interrupted, exiting ... 1831 tests ran as expected, 1 didn't (2168 didn't run): Correction. I was not able to reproduce the issue, I got a failure not a crash. Please disregard my comment on 2020-02-25 07:18:13 PST. Youenn fixed this via bug 208208. Still need to unmark the test. Jason or Youenn, could you please take care of that? Created attachment 392122 [details]
Patch
Comment on attachment 392122 [details] Patch Clearing flags on attachment: 392122 Committed r257706: <https://trac.webkit.org/changeset/257706> All reviewed patches have been landed. Closing bug. |