Bug 208151

Summary: LLInt should fast path for jtrue/false on Symbols and Objects
Product: WebKit Reporter: Keith Miller <keith_miller>
Component: New BugsAssignee: Keith Miller <keith_miller>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ews-watchlist, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description Keith Miller 2020-02-24 12:28:07 PST
LLInt should fast path for jtrue/false on Symbols and Objects
Comment 1 Keith Miller 2020-02-24 12:32:55 PST
Created attachment 391566 [details]
Patch
Comment 2 Yusuke Suzuki 2020-02-24 12:52:17 PST
Comment on attachment 391566 [details]
Patch

Does this handle masquerade-as-undefined objects? These objects need to be evaluated as false in certain context IIRC.
Comment 3 Keith Miller 2020-02-24 13:58:52 PST
(In reply to Yusuke Suzuki from comment #2)
> Comment on attachment 391566 [details]
> Patch
> 
> Does this handle masquerade-as-undefined objects? These objects need to be
> evaluated as false in certain context IIRC.

Yeah, probably, I should have run-non-test262 tests before uploading...
Comment 4 Keith Miller 2020-02-24 14:23:45 PST
Created attachment 391576 [details]
Patch
Comment 5 Yusuke Suzuki 2020-02-24 15:19:54 PST
Comment on attachment 391576 [details]
Patch

r=me
Comment 6 WebKit Commit Bot 2020-02-24 15:51:33 PST
Comment on attachment 391576 [details]
Patch

Clearing flags on attachment: 391576

Committed r257270: <https://trac.webkit.org/changeset/257270>
Comment 7 WebKit Commit Bot 2020-02-24 15:51:35 PST
All reviewed patches have been landed.  Closing bug.
Comment 8 Radar WebKit Bug Importer 2020-02-24 15:52:22 PST
<rdar://problem/59744579>