Bug 208139

The following tests became flaky after r256967:

  * http/tests/cache/disk-cache/disk-cache-disable.html [ Pass Failure ]
  * http/tests/cache/link-prefetch-main-resource.html [ Pass Failure ]
  * http/tests/inspector/network/resource-response-source-disk-cache.html [ Pass Failure ]
  * http/tests/inspector/network/resource-sizes-disk-cache.html [ Pass Failure ]
  * http/wpt/fetch/disable-speculative-load-for-xhr-and-fetch-loads.html [ Pass Failure ]
  * imported/w3c/web-platform-tests/fetch/api/basic/conditional-get.html [ Pass Failure ]
  * imported/w3c/web-platform-tests/fetch/api/request/request-cache-default.html [ Pass Failure ]
  * imported/w3c/web-platform-tests/fetch/api/request/request-cache-force-cache.html [ Pass Failure ]
  * imported/w3c/web-platform-tests/fetch/api/request/request-cache-reload.html [ Pass Failure ]
  * imported/w3c/web-platform-tests/service-workers/service-worker/update-no-cache-request-headers.https.html [ Pass Failure ]

Actual failing range is [r256918-r257038], but within those revision numbers I think r256967 is the most likely cause for the regression.

--- /home/igalia/dpino/workspace/webkit-gtk/layout-test-results/retries/http/tests/cache/disk-cache/disk-cache-disable-expected.txt
+++ /home/igalia/dpino/workspace/webkit-gtk/layout-test-results/retries/http/tests/cache/disk-cache/disk-cache-disable-actual.txt
@@ -6,7 +6,7 @@
 Default (cache enabled)
 --------Testing loads from disk cache--------
 response headers: {"Cache-control":"max-age=100"}
-response source: Disk cache
+response source: Network
 
 --------Testing loads through memory cache (XHR behavior)--------
 response headers: {"Cache-control":"max-age=100"}

--- /home/igalia/dpino/workspace/webkit-gtk/layout-test-results/retries/http/tests/cache/link-prefetch-main-resource-expected.txt
+++ /home/igalia/dpino/workspace/webkit-gtk/layout-test-results/retries/http/tests/cache/link-prefetch-main-resource-actual.txt
@@ -1 +1 @@
-PASS
+FAIL: resource is not in the disk cache.

--- /home/igalia/dpino/workspace/webkit-gtk/layout-test-results/http/tests/inspector/network/resource-response-source-disk-cache-expected.txt
+++ /home/igalia/dpino/workspace/webkit-gtk/layout-test-results/http/tests/inspector/network/resource-response-source-disk-cache-actual.txt
@@ -11,5 +11,7 @@
 PASS: Resource should be created.
 PASS: Resource should receive a Response.
 PASS: statusCode should be 200
-PASS: responseSource should be Symbol(disk-cache)
+FAIL: responseSource should be Symbol(disk-cache)
+    Expected: Symbol(disk-cache)
+    Actual: Symbol(network)

--- /home/igalia/dpino/workspace/webkit-gtk/layout-test-results/http/tests/inspector/network/resource-sizes-disk-cache-expected.txt
+++ /home/igalia/dpino/workspace/webkit-gtk/layout-test-results/http/tests/inspector/network/resource-sizes-disk-cache-actual.txt
@@ -7,14 +7,22 @@
 -- Running test case: Resource.Size.DiskCache.Basic
 PASS: statusCode should be 200.
 PASS: compressed should be false.
-PASS: responseSource should be Symbol(disk-cache).
+FAIL: responseSource should be Symbol(disk-cache).
+    Expected: Symbol(disk-cache)
+    Actual: Symbol(network)
 size: 529
-requestBodyTransferSize: 0
-responseBodyTransferSize: 0
-estimatedNetworkEncodedSize: 0
-networkEncodedSize: 0
+requestBodyTransferSize: NaN
+responseBodyTransferSize: NaN
+estimatedNetworkEncodedSize: 529
+networkEncodedSize: NaN
 PASS: estimatedTotalTransferSize should be >= (encoded body size + headers).
-PASS: networkTotalTransferSize should be >= (encoded body size + headers).
-PASS: requestHeadersTransferSize should be empty.
-PASS: responseHeadersTransferSize should be empty.
+FAIL: networkTotalTransferSize should be >= (encoded body size + headers).
+    Expected: greater than or equal to 0
+    Actual: NaN
+FAIL: requestHeadersTransferSize should be empty.
+    Expected: 0
+    Actual: NaN
+FAIL: responseHeadersTransferSize should be empty.
+    Expected: 0
+    Actual: NaN

--- /home/igalia/dpino/workspace/webkit-gtk/layout-test-results/http/wpt/fetch/disable-speculative-load-for-xhr-and-fetch-loads-expected.txt
+++ /home/igalia/dpino/workspace/webkit-gtk/layout-test-results/http/wpt/fetch/disable-speculative-load-for-xhr-and-fetch-loads-actual.txt
@@ -1,4 +1,5 @@
 
-PASS Ensure fetch is not speculatively loaded 
-PASS Ensure XHR is not speculatively loaded 
 
+FAIL Ensure fetch is not speculatively loaded assert_equals: after reload expected "0" but got "1"
+FAIL Ensure XHR is not speculatively loaded assert_equals: after reload expected "0" but got "1"


--- /home/igalia/dpino/workspace/webkit-gtk/layout-test-results/imported/w3c/web-platform-tests/fetch/api/basic/conditional-get-expected.txt
+++ /home/igalia/dpino/workspace/webkit-gtk/layout-test-results/imported/w3c/web-platform-tests/fetch/api/basic/conditional-get-actual.txt
@@ -1,3 +1,3 @@

-PASS Testing conditional GET with ETags 
+FAIL Testing conditional GET with ETags assert_equals: expected (string) "304" but got (object) null


--- /home/igalia/dpino/workspace/webkit-gtk/layout-test-results/imported/w3c/web-platform-tests/fetch/api/request/request-cache-default-expected.txt
+++ /home/igalia/dpino/workspace/webkit-gtk/layout-test-results/imported/w3c/web-platform-tests/fetch/api/request/request-cache-default-actual.txt
@@ -1,8 +1,8 @@
 
 PASS RequestCache "default" mode checks the cache for previously cached content and goes to the network for stale responses with Etag and stale response
 PASS RequestCache "default" mode checks the cache for previously cached content and goes to the network for stale responses with Last-Modified and stale response
-PASS RequestCache "default" mode checks the cache for previously cached content and avoids going to the network if a fresh response exists with Etag and fresh response 
-PASS RequestCache "default" mode checks the cache for previously cached content and avoids going to the network if a fresh response exists with Last-Modified and fresh response 
+FAIL RequestCache "default" mode checks the cache for previously cached content and avoids going to the network if a fresh response exists with Etag and fresh response assert_equals: expected 1 but got 2
+FAIL RequestCache "default" mode checks the cache for previously cached content and avoids going to the network if a fresh response exists with Last-Modified and fresh response assert_equals: expected 1 but got
 PASS Responses with the "Cache-Control: no-store" header are not stored in the cache with Etag and stale response  
 PASS Responses with the "Cache-Control: no-store" header are not stored in the cache with Last-Modified and stale response 
 PASS Responses with the "Cache-Control: no-store" header are not stored in the cache with Etag and fresh response 

--- /home/igalia/dpino/workspace/webkit-gtk/layout-test-results/imported/w3c/web-platform-tests/fetch/api/request/request-cache-force-cache-expected.txt
+++ /home/igalia/dpino/workspace/webkit-gtk/layout-test-results/imported/w3c/web-platform-tests/fetch/api/request/request-cache-force-cache-actual.txt
@@ -1,8 +1,8 @@

-PASS RequestCache "force-cache" mode checks the cache for previously cached content and avoid revalidation for stale responses with Etag and stale response 
-PASS RequestCache "force-cache" mode checks the cache for previously cached content and avoid revalidation for stale responses with Last-Modified and stale response 
-PASS RequestCache "force-cache" mode checks the cache for previously cached content and avoid revalidation for fresh responses with Etag and fresh response 
-PASS RequestCache "force-cache" mode checks the cache for previously cached content and avoid revalidation for fresh responses with Last-Modified and fresh response 
+FAIL RequestCache "force-cache" mode checks the cache for previously cached content and avoid revalidation for stale responses with Etag and stale response assert_equals: expected 1 but got 2
+FAIL RequestCache "force-cache" mode checks the cache for previously cached content and avoid revalidation for stale responses with Last-Modified and stale response assert_equals: expected 1 but got 2
+FAIL RequestCache "force-cache" mode checks the cache for previously cached content and avoid revalidation for fresh responses with Etag and fresh response assert_equals: expected 1 but got 2
+FAIL RequestCache "force-cache" mode checks the cache for previously cached content and avoid revalidation for fresh responses with Last-Modified and fresh response assert_equals: expected 1 but got 2
 PASS RequestCache "force-cache" mode checks the cache for previously cached content and goes to the network if a cached response is not found with Etag and stale response
 PASS RequestCache "force-cache" mode checks the cache for previously cached content and goes to the network if a cached response is not found with Last-Modified and stale response 
 PASS RequestCache "force-cache" mode checks the cache for previously cached content and goes to the network if a cached response is not found with Etag and fresh response 
@@ -13,6 +13,6 @@
 PASS RequestCache "force-cache" mode checks the cache for previously cached content and goes to the network if a cached response would vary with Last-Modified and fresh response 
 PASS RequestCache "force-cache" stores the response in the cache if it goes to the network with Etag and stale response 
 PASS RequestCache "force-cache" stores the response in the cache if it goes to the network with Last-Modified and stale response 
-PASS RequestCache "force-cache" stores the response in the cache if it goes to the network with Etag and fresh response 
-PASS RequestCache "force-cache" stores the response in the cache if it goes to the network with Last-Modified and fresh response 
+FAIL RequestCache "force-cache" stores the response in the cache if it goes to the network with Etag and fresh response assert_equals: expected 1 but got 2
+FAIL RequestCache "force-cache" stores the response in the cache if it goes to the network with Last-Modified and fresh response assert_equals: expected 1 but got 2


--- /home/igalia/dpino/workspace/webkit-gtk/layout-test-results/imported/w3c/web-platform-tests/fetch/api/request/request-cache-reload-expected.txt
+++ /home/igalia/dpino/workspace/webkit-gtk/layout-test-results/imported/w3c/web-platform-tests/fetch/api/request/request-cache-reload-actual.txt
@@ -5,10 +5,10 @@
 PASS RequestCache "reload" mode does not check the cache for previously cached content and goes to the network regardless with Last-Modified and fresh response
 PASS RequestCache "reload" mode does store the response in the cache with Etag and stale response 
 PASS RequestCache "reload" mode does store the response in the cache with Last-Modified and stale response 
-PASS RequestCache "reload" mode does store the response in the cache with Etag and fresh response 
-PASS RequestCache "reload" mode does store the response in the cache with Last-Modified and fresh response 
+FAIL RequestCache "reload" mode does store the response in the cache with Etag and fresh response assert_equals: expected 1 but got 2
+FAIL RequestCache "reload" mode does store the response in the cache with Last-Modified and fresh response assert_equals: expected 1 but got 2
 PASS RequestCache "reload" mode does store the response in the cache even if a previous response is already stored with Etag and stale response 
 PASS RequestCache "reload" mode does store the response in the cache even if a previous response is already stored with Last-Modified and stale response 
-PASS RequestCache "reload" mode does store the response in the cache even if a previous response is already stored with Etag and fresh response 
-PASS RequestCache "reload" mode does store the response in the cache even if a previous response is already stored with Last-Modified and fresh response 
+FAIL RequestCache "reload" mode does store the response in the cache even if a previous response is already stored with Etag and fresh response assert_equals: expected 2 but got 3
+FAIL RequestCache "reload" mode does store the response in the cache even if a previous response is already stored with Last-Modified and fresh response assert_equals: expected 2 but got 3


--- /home/igalia/dpino/workspace/webkit-gtk/layout-test-results/imported/w3c/web-platform-tests/service-workers/service-worker/update-no-cache-request-headers.https-expected.txt
+++ /home/igalia/dpino/workspace/webkit-gtk/layout-test-results/imported/w3c/web-platform-tests/service-workers/service-worker/update-no-cache-request-headers.https-actual.txt
@@ -1,3 +1,3 @@
 
-PASS headers in no-cache mode 
+FAIL headers in no-cache mode assert_equals: expected (string) "etag" but got (undefined) undefined