Bug 208135

Summary:

Remove throttling code from RenderLayerCompositor

Product:

WebKit

Reporter:

Antti Koivisto <koivisto>

Component:

Layout and Rendering

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, cmarcelo, commit-queue, esprehn+autocc, ews-watchlist, fred.wang, glenn, gyuyoung.kim, kondapallykalyan, luiz, noam, pdr, ryuan.choi, sergio, simon.fraser, webkit-bug-importer, zalan, zeno

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
patch	none
patch	none
patch	none
patch	none
patch	none
patch	none
revert back to notifyFlushRequired	none
revert back to notifyFlushRequired	none
revert back to notifyFlushRequired	none
revert back to notifyFlushRequired	none

Antti Koivisto

Reported 2020-02-24 07:43:54 PST

It is only used on WK1, adds lots of complexity and is not very effective.

Attachments
patch (26.80 KB, patch) 2020-02-24 07:47 PST, Antti Koivisto	no flags	Details Formatted Diff Diff
patch (26.91 KB, patch) 2020-02-24 07:56 PST, Antti Koivisto	no flags	Details Formatted Diff Diff
patch (26.91 KB, patch) 2020-02-24 08:08 PST, Antti Koivisto	no flags	Details Formatted Diff Diff
patch (31.10 KB, patch) 2020-02-25 00:26 PST, Antti Koivisto	no flags	Details Formatted Diff Diff
patch (31.10 KB, patch) 2020-02-25 01:04 PST, Antti Koivisto	no flags	Details Formatted Diff Diff
patch (31.76 KB, patch) 2020-02-25 01:15 PST, Antti Koivisto	no flags	Details Formatted Diff Diff
revert back to notifyFlushRequired (13.57 KB, patch) 2020-02-26 03:15 PST, Antti Koivisto	no flags	Details Formatted Diff Diff
revert back to notifyFlushRequired (13.57 KB, patch) 2020-02-26 03:37 PST, Antti Koivisto	no flags	Details Formatted Diff Diff
revert back to notifyFlushRequired (14.18 KB, patch) 2020-02-26 04:32 PST, Antti Koivisto	no flags	Details Formatted Diff Diff
revert back to notifyFlushRequired (15.86 KB, patch) 2020-02-26 04:34 PST, Antti Koivisto	no flags	Details Formatted Diff Diff
Show Obsolete (8) View All Add attachment proposed patch, testcase, etc.

Antti Koivisto

Comment 1 2020-02-24 07:47:42 PST

Created attachment 391538 [details] patch

Antti Koivisto

Comment 2 2020-02-24 07:56:59 PST

Created attachment 391541 [details] patch

Antti Koivisto

Comment 3 2020-02-24 08:08:16 PST

Created attachment 391543 [details] patch

Simon Fraser (smfr)

Comment 4 2020-02-24 10:59:19 PST

Nice.

Antti Koivisto

Comment 5 2020-02-25 00:26:10 PST

Created attachment 391631 [details] patch

Antti Koivisto

Comment 6 2020-02-25 01:04:48 PST

Created attachment 391633 [details] patch

Antti Koivisto

Comment 7 2020-02-25 01:15:44 PST

Created attachment 391635 [details] patch

WebKit Commit Bot

Comment 8 2020-02-25 08:36:05 PST

Comment on attachment 391635 [details] patch Clearing flags on attachment: 391635 Committed r257357: <https://trac.webkit.org/changeset/257357>

WebKit Commit Bot

Comment 9 2020-02-25 08:36:08 PST

All reviewed patches have been landed. Closing bug.

Radar WebKit Bug Importer

Comment 10 2020-02-25 08:37:16 PST

<rdar://problem/59765410>

Simon Fraser (smfr)

Comment 11 2020-02-25 11:04:23 PST

Comment on attachment 391635 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=391635&action=review > Source/WebCore/platform/graphics/GraphicsLayerClient.h:101 > - virtual void notifyFlushRequired(const GraphicsLayer*) { } > + virtual void notifyRenderingUpdateRequired(const GraphicsLayer*) { } I would not have renamed this one, because it should have the same name as GraphicsLayer::flushCompositingState() which you did not rename. Down here we're flushing, not doing rendering updates.

Antti Koivisto

Comment 12 2020-02-25 11:53:11 PST

> I would not have renamed this one, because it should have the same name as > GraphicsLayer::flushCompositingState() which you did not rename. > > Down here we're flushing, not doing rendering updates. Ok, I'll rename it back.

Antti Koivisto

Comment 13 2020-02-26 03:15:07 PST

Created attachment 391732 [details] revert back to notifyFlushRequired

Antti Koivisto

Comment 14 2020-02-26 03:36:52 PST

add a followup

Antti Koivisto

Comment 15 2020-02-26 03:37:38 PST

Created attachment 391734 [details] revert back to notifyFlushRequired

Antti Koivisto

Comment 16 2020-02-26 04:32:37 PST

Created attachment 391736 [details] revert back to notifyFlushRequired

Antti Koivisto

Comment 17 2020-02-26 04:34:41 PST

Created attachment 391737 [details] revert back to notifyFlushRequired

WebKit Commit Bot

Comment 18 2020-02-26 05:38:04 PST

Comment on attachment 391737 [details] revert back to notifyFlushRequired Clearing flags on attachment: 391737 Committed r257465: <https://trac.webkit.org/changeset/257465>

WebKit Commit Bot

Comment 19 2020-02-26 05:38:06 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.