| Summary: | Remove throttling code from RenderLayerCompositor | ||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Antti Koivisto <koivisto> | ||||||||||||||||||||||
| Component: | Layout and Rendering | Assignee: | Nobody <webkit-unassigned> | ||||||||||||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||||||||||||
| Severity: | Normal | CC: | bfulgham, cmarcelo, commit-queue, esprehn+autocc, ews-watchlist, fred.wang, glenn, gyuyoung.kim, kondapallykalyan, luiz, noam, pdr, ryuan.choi, sergio, simon.fraser, webkit-bug-importer, zalan, zeno | ||||||||||||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||||||||||||
| Hardware: | Unspecified | ||||||||||||||||||||||||
| OS: | Unspecified | ||||||||||||||||||||||||
| Attachments: |
|
||||||||||||||||||||||||
|
Description
Antti Koivisto
2020-02-24 07:43:54 PST
Created attachment 391538 [details]
patch
Created attachment 391541 [details]
patch
Created attachment 391543 [details]
patch
Nice. Created attachment 391631 [details]
patch
Created attachment 391633 [details]
patch
Created attachment 391635 [details]
patch
Comment on attachment 391635 [details] patch Clearing flags on attachment: 391635 Committed r257357: <https://trac.webkit.org/changeset/257357> All reviewed patches have been landed. Closing bug. Comment on attachment 391635 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=391635&action=review > Source/WebCore/platform/graphics/GraphicsLayerClient.h:101 > - virtual void notifyFlushRequired(const GraphicsLayer*) { } > + virtual void notifyRenderingUpdateRequired(const GraphicsLayer*) { } I would not have renamed this one, because it should have the same name as GraphicsLayer::flushCompositingState() which you did not rename. Down here we're flushing, not doing rendering updates. > I would not have renamed this one, because it should have the same name as
> GraphicsLayer::flushCompositingState() which you did not rename.
>
> Down here we're flushing, not doing rendering updates.
Ok, I'll rename it back.
Created attachment 391732 [details]
revert back to notifyFlushRequired
add a followup Created attachment 391734 [details]
revert back to notifyFlushRequired
Created attachment 391736 [details]
revert back to notifyFlushRequired
Created attachment 391737 [details]
revert back to notifyFlushRequired
Comment on attachment 391737 [details] revert back to notifyFlushRequired Clearing flags on attachment: 391737 Committed r257465: <https://trac.webkit.org/changeset/257465> All reviewed patches have been landed. Closing bug. |