Bug 208127

Summary: Protect from null session in NetworkDataTaskCocoa::restrictRequestReferrerToOriginIfNeeded
Product: WebKit Reporter: youenn fablet <youennf>
Component: Page LoadingAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, beidson, cdumez, commit-queue, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

youenn fablet
Reported 2020-02-24 02:21:30 PST
Protect from null session in NetworkDataTaskCocoa::restrictRequestReferrerToOriginIfNeeded
Attachments
Patch (1.75 KB, patch)
2020-02-24 02:31 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2020-02-24 02:30:29 PST
<rdar://problem/57937917>
youenn fablet
Comment 2 2020-02-24 02:31:27 PST
Created attachment 391520 [details] Patch
youenn fablet
Comment 3 2020-02-24 02:44:22 PST
It seems that we should fail all NetworkResourceLoader when the corresponding session goes away. For now, protecting NetworkDataTask seems fine.
WebKit Commit Bot
Comment 4 2020-02-24 08:41:48 PST
The commit-queue encountered the following flaky tests while processing attachment 391520 [details]: editing/spelling/spellcheck-async-remove-frame.html bug 158401 (authors: morrita@google.com, rniwa@webkit.org, and tony@chromium.org) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 5 2020-02-24 08:42:23 PST
Comment on attachment 391520 [details] Patch Clearing flags on attachment: 391520 Committed r257209: <https://trac.webkit.org/changeset/257209>
WebKit Commit Bot
Comment 6 2020-02-24 08:42:24 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.