Bug 208117

Summary:	[WPE][GTK] Building with -D_FORTIFY_SOURCE=n breaks gtk-doc
Product:	WebKit	Reporter:	Adrian Perez <aperez>
Component:	Tools / Tests	Assignee:	Nobody <webkit-unassigned>
Status:	RESOLVED WONTFIX
Severity:	Normal	CC:	mcatanzaro
Priority:	P2
Version:	WebKit Local Build
Hardware:	Unspecified
OS:	Unspecified

Description Adrian Perez 2020-02-23 23:17:25 PST

[6/61] Generating ../docs-build.stamp
FAILED: docs-build.stamp 
cd /home/aperez/devel/WebKit/build-wpe-nouni && /usr/bin/cmake -E env CC=/usr/lib/ccache/bin/clang "CFLAGS=-fdiagnostics-color=always -fcolor-diagnostics -Wextra -Wall -Wno-parentheses-equality -Qunused-arguments -Wwrite-strings -Wundef -Wpointer-arith -Wmissing-format-attribute -Wformat-security -Wcast-align -flto=thin   -D_FORTIFY_SOURCE=2 -fstack-protector-strong -fno-strict-aliasing -fno-exceptions -Wno-unused-parameter" "LDFLAGS=-stdlib=libc++  -Wl,-O1,--sort-common  -fuse-ld=lld -flto=thin -Wl,--thinlto-jobs=3,--thinlto-cache-dir=/home/aperez/.cache/lld-thinlto,--thinlto-cache-policy,cache_size=0%:cache_size_bytes=1g  -Wl,--no-undefined,--as-needed,-z,relro,-z,now,-z,noexecstack" /home/aperez/devel/WebKit/Tools/gtkdoc/generate-gtkdoc --wpe && touch docs-build.stamp
In file included from wpe-webextensions-1.0-scan.c:2:
In file included from /usr/include/string.h:26:
In file included from /usr/include/bits/libc-header-start.h:33:
/usr/include/features.h:397:4: warning: _FORTIFY_SOURCE requires compiling with optimization (-O) [-W#warnings]
#  warning _FORTIFY_SOURCE requires compiling with optimization (-O)
   ^
1 warning generated.
html/wpe-webextensions-1.0/WebKitConsoleMessage.html:163: warning: no link for: "api-index-2.12" -> (2.12).
html/wpe-webextensions-1.0/WebKitFrame.html:152: warning: no link for: "api-index-2.26" -> (2.26).
html/wpe-webextensions-1.0/WebKitFrame.html:181: warning: no link for: "api-index-2.2" -> (2.2).
html/wpe-webextensions-1.0/WebKitWebEditor.html:121: warning: no link for: "api-index-2.10" -> (2.10).
html/wpe-webextensions-1.0/WebKitWebExtension.html:134: warning: no link for: "webkit-web-extension-initialize" -> (<code class="function">webkit_web_extension_initialize()</code>).
html/wpe-webextensions-1.0/WebKitWebExtension.html:135: warning: no link for: "webkit-web-extension-initialize-with-user-data" -> (<code class="function">webkit_web_extension_initialize_with_user_data()</code>).
html/wpe-webextensions-1.0/WebKitWebExtension.html:309: warning: no link for: "api-index-2.4" -> (2.4).
html/wpe-webextensions-1.0/WebKitWebExtension.html:355: warning: no link for: "WebKitUserMessage" -> (<span class="type">WebKitUserMessage</span>).
html/wpe-webextensions-1.0/WebKitWebExtension.html:405: warning: no link for: "api-index-2.28" -> (2.28).
html/wpe-webextensions-1.0/WebKitWebExtension.html:508: warning: no link for: "webkit-user-message-send-reply" -> (<code class="function">webkit_user_message_send_reply()</code>).
html/wpe-webextensions-1.0/WebKitWebHitTestResult.html:121: warning: no link for: "api-index-2.8" -> (2.8).
html/wpe-webextensions-1.0/WebKitWebPage.html:683: warning: no link for: "api-index-2.16" -> (2.16).
html/wpe-webextensions-1.0/WebKitWebPage.html:816: warning: no link for: "WEBKIT-USER-MESSAGE-UNHANDLED-MESSAGE:CAPS" -> (<code class="literal">WEBKIT_USER_MESSAGE_UNHANDLED_MESSAGE</code>).
html/wpe-webextensions-1.0/WebKitWebPage.html:910: warning: no link for: "WebKitFormSubmissionEventType" -> (<span class="type">WebKitFormSubmissionEventType</span>).
ninja: build stopped: subcommand failed.

Comment 1 Adrian Perez 2020-02-23 23:20:23 PST

(In reply to Adrian Perez from comment #0)
> [6/61] Generating ../docs-build.stamp
> FAILED: docs-build.stamp 
> cd /home/aperez/devel/WebKit/build-wpe-nouni && /usr/bin/cmake -E env
> CC=/usr/lib/ccache/bin/clang "CFLAGS=-fdiagnostics-color=always
> -fcolor-diagnostics -Wextra -Wall -Wno-parentheses-equality
> -Qunused-arguments -Wwrite-strings -Wundef -Wpointer-arith
> -Wmissing-format-attribute -Wformat-security -Wcast-align -flto=thin  
> -D_FORTIFY_SOURCE=2 -fstack-protector-strong -fno-strict-aliasing
> -fno-exceptions -Wno-unused-parameter" "LDFLAGS=-stdlib=libc++ 
> -Wl,-O1,--sort-common  -fuse-ld=lld -flto=thin
> -Wl,--thinlto-jobs=3,--thinlto-cache-dir=/home/aperez/.cache/lld-thinlto,--
> thinlto-cache-policy,cache_size=0%:cache_size_bytes=1g 
> -Wl,--no-undefined,--as-needed,-z,relro,-z,now,-z,noexecstack"
> /home/aperez/devel/WebKit/Tools/gtkdoc/generate-gtkdoc --wpe && touch
> docs-build.stamp
>
> [...]

In the command here we can see that the compiler is indeed right (how
amazing that it usually is!) and the -O𝑛 flag is not being passed in
the CFLAGS environment variable that is forwarded to the generate-gtkdoc
script.

Comment 2 Michael Catanzaro 2022-07-06 06:31:01 PDT

You removed the gtk-doc, good job!