Bug 208078

Summary: [WebGL] Unskip runnable WebGL 2.0.0 conformance suite for mac
Product: WebKit Reporter: Justin Fan <justin_fan>
Component: New BugsAssignee: Justin Fan <justin_fan>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dino, jacob_uphoff, jonlee, Lawrence.j, tsavell, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=208188
https://bugs.webkit.org/show_bug.cgi?id=209479
https://bugs.webkit.org/show_bug.cgi?id=209480
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch for landing none

Justin Fan
Reported 2020-02-21 16:18:00 PST
[WebGL] Unskip runnable WebGL 2.0.0 conformance suite
Attachments
Patch (89.88 KB, patch)
2020-02-21 16:29 PST, Justin Fan 		no flags
DetailsFormatted DiffDiff
Patch (92.60 KB, patch)
2020-02-24 13:34 PST, Justin Fan 		no flags
DetailsFormatted DiffDiff
Patch (92.52 KB, patch)
2020-02-24 13:37 PST, Justin Fan 		no flags
DetailsFormatted DiffDiff
Patch for landing (92.53 KB, patch)
2020-02-24 15:58 PST, Justin Fan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Justin Fan
Comment 1 2020-02-21 16:29:16 PST
Created attachment 391432 [details] Patch
Radar WebKit Bug Importer
Comment 2 2020-02-21 16:41:34 PST
<rdar://problem/59688268>
Justin Fan
Comment 3 2020-02-24 13:34:19 PST
Created attachment 391571 [details] Patch
Justin Fan
Comment 4 2020-02-24 13:37:46 PST
Created attachment 391572 [details] Patch
Jon Lee
Comment 5 2020-02-24 14:09:49 PST
Comment on attachment 391572 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=391572&action=review > LayoutTests/TestExpectations:3344 > +# DEQP will likely always be skipped on regular bots due to runtime. There should be assertive clarity here. "will likely always" is hedging. When it changes, it changes. "runtime" could be misread confusingly as runtime switch rather than the literal time it takes. "DEQP is skipped on the main fleet of bots because of the long run time."
Justin Fan
Comment 6 2020-02-24 14:23:56 PST
(In reply to Jon Lee from comment #5) > Comment on attachment 391572 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=391572&action=review > > > LayoutTests/TestExpectations:3344 > > +# DEQP will likely always be skipped on regular bots due to runtime. > > There should be assertive clarity here. "will likely always" is hedging. > When it changes, it changes. "runtime" could be misread confusingly as > runtime switch rather than the literal time it takes. > > "DEQP is skipped on the main fleet of bots because of the long run time." Thanks! Will be addressed in the final patch; just letting this one go through tests again
Justin Fan
Comment 7 2020-02-24 15:58:42 PST
Created attachment 391590 [details] Patch for landing
WebKit Commit Bot
Comment 8 2020-02-24 16:48:57 PST
Comment on attachment 391590 [details] Patch for landing Clearing flags on attachment: 391590 Committed r257283: <https://trac.webkit.org/changeset/257283>
WebKit Commit Bot
Comment 9 2020-02-24 16:49:12 PST
All reviewed patches have been landed. Closing bug.
Justin Fan
Comment 11 2020-02-25 15:19:40 PST
(In reply to Jacob Uphoff from comment #10) > It looks like these tests are all failing across the board. > > https://results.webkit.org/?suite=layout-tests&suite=layout- > tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout- > tests&test=webgl%2F2.0.0%2Fconformance%2Fbuffers%2Fbuffer-uninitialized. > html&test=webgl%2F2.0.0%2Fconformance%2Fextensions%2Fangle-instanced-arrays. > html&test=webgl%2F2.0.0%2Fconformance%2Frendering%2Fclipping-wide-points. > html&test=webgl%2F2.0.0%2Fconformance2%2Frenderbuffers%2Fmultisampled- > renderbuffer-initialization.html&test=webgl%2F2.0. > 0%2Fconformance2%2Frendering%2Fclipping-wide-points.html&test=webgl%2F2.0. > 0%2Fconformance2%2Ftextures%2Fmisc%2Ftex-3d-size-limit.html Follow-up: https://bugs.webkit.org/show_bug.cgi?id=208211
Jason Lawrence
Comment 12 2020-02-26 15:38:38 PST
I have marked webgl/2.0.0/conformance2/textures/misc/copy-texture-image-luma-format.html as pass on timeout here: https://trac.webkit.org/changeset/257523/webkit
Truitt Savell
Comment 13 2020-03-13 16:00:38 PDT
webgl/2.0.0/conformance/attribs/gl-vertexattribpointer.html This test is timing out consistently on Mac Debug wk1 History: https://results.webkit.org/?suite=layout-tests&test=webgl%2F2.0.0%2Fconformance%2Fattribs%2Fgl-vertexattribpointer.html
Note You need to log in before you can comment on or make changes to this bug.