Bug 208064

Summary:

[ews] Add build step to Validate ChangeLog for commit-queue

Product:

WebKit

Reporter:

Aakash Jain <aakash_jain>

Component:

Tools / Tests

Assignee:

Aakash Jain <aakash_jain>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aakash_jain, ap, jbedard, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

Other

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	jbedard: review+

Description Aakash Jain 2020-02-21 10:36:00 PST

Add build step to Validate ChangeLog. This step would be required for commit-queue, to validate whether the ChangeLog looks fine (i.e. doesn't contains OOPS, the reviewer name in 'Reviewed by XYZ' is a valid reviewer).

Comment 1 Aakash Jain 2020-02-21 10:40:03 PST

Created attachment 391409 [details]
Patch

Comment 2 Aakash Jain 2020-02-21 10:41:05 PST

Sample run: https://ews-build.webkit-uat.org/#/builders/26/builds/698

Comment 3 Jonathan Bedard 2020-02-21 11:59:30 PST

(In reply to Aakash Jain from comment #2)
> Sample run: https://ews-build.webkit-uat.org/#/builders/26/builds/698

Do you have a successful example?

Comment 4 Aakash Jain 2020-02-21 12:14:39 PST

(In reply to Jonathan Bedard from comment #3)
> Do you have a successful example?
https://ews-build.webkit-uat.org/#/builders/26/builds/735

Comment 5 Aakash Jain 2020-02-21 13:12:06 PST

Committed r257157: <https://trac.webkit.org/changeset/257157>

Comment 6 Radar WebKit Bug Importer 2020-02-21 13:13:15 PST

<rdar://problem/59679885>

Comment 7 Aakash Jain 2020-03-19 15:07:18 PDT

This change seems to be working fine. e.g.:

ChangeLog missing Unreviewed/Reviewed-by text: https://ews-build.webkit.org/#/builders/28/builds/64

ChangeLog containing OOPS: https://ews-build.webkit.org/#/builders/28/builds/52