Bug 208037

Summary: Add fidelity.com to the desktop class quirks list
Product: WebKit Reporter: John Wilander <wilander>
Component: WebKit Misc.Assignee: John Wilander <wilander>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

Description John Wilander 2020-02-20 16:09:53 PST
It seems fidelity.com is binding an event handler to both clicks and touches on its document and then only unbinding the click event. This leads to a broken experience when the browser supports both click and touch events. We should add fidelity.com to the desktop class quirks list until they can fix their website.
Comment 1 John Wilander 2020-02-20 16:12:40 PST
<rdar://problem/59480381>
Comment 2 John Wilander 2020-02-20 16:13:37 PST
Created attachment 391353 [details]
Patch
Comment 3 Brent Fulgham 2020-02-20 16:25:00 PST
Comment on attachment 391353 [details]
Patch

Very sad. Can we paste the radar here so we can remove this once we get a site change?
Comment 4 John Wilander 2020-02-20 16:27:16 PST
(In reply to Brent Fulgham from comment #3)
> Comment on attachment 391353 [details]
> Patch
> 
> Very sad. Can we paste the radar here so we can remove this once we get a
> site change?

You mean like a FIXME in the code? Because the radar is above here on the Bugzilla.
Comment 5 Brent Fulgham 2020-02-20 16:32:53 PST
(In reply to John Wilander from comment #4)
> (In reply to Brent Fulgham from comment #3)
> > Comment on attachment 391353 [details]
> > Patch
> > 
> > Very sad. Can we paste the radar here so we can remove this once we get a
> > site change?
> 
> You mean like a FIXME in the code? Because the radar is above here on the
> Bugzilla.

Yes. Just add a FIXME and reference the radar tracking the communication with Fidelity.
Comment 6 John Wilander 2020-02-20 16:34:24 PST
Got it. Thanks!
Comment 7 John Wilander 2020-02-20 16:41:14 PST
Created attachment 391358 [details]
Patch for landing
Comment 8 WebKit Commit Bot 2020-02-20 17:25:37 PST
Comment on attachment 391358 [details]
Patch for landing

Clearing flags on attachment: 391358

Committed r257106: <https://trac.webkit.org/changeset/257106>
Comment 9 WebKit Commit Bot 2020-02-20 17:25:38 PST
All reviewed patches have been landed.  Closing bug.