| Summary: | WebIDBServer resume should return early if suspend does not happen | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Sihui Liu <sihui_liu> | ||||||
| Component: | New Bugs | Assignee: | Sihui Liu <sihui_liu> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | achristensen, beidson, cdumez, commit-queue, ggaren, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Sihui Liu
2020-02-20 13:02:54 PST
Created attachment 391323 [details]
Patch
Comment on attachment 391323 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=391323&action=review r=me > Source/WebKit/NetworkProcess/IndexedDB/WebIDBServer.cpp:106 > + // Lock is not held by suspend. I'm not sure this comment adds information. I guess this change was motivated by a crash unlocking. But it will always be true that we do not want to resume if we did not suspend, regardless of what logic or behavior follows this check; the check is not particular to the lock. Created attachment 391342 [details]
Patch for landing
Comment on attachment 391342 [details] Patch for landing Clearing flags on attachment: 391342 Committed r257103: <https://trac.webkit.org/changeset/257103> All reviewed patches have been landed. Closing bug. |