| Summary: | [ews] Add build step to set cq- flag on bugzilla patch | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Aakash Jain <aakash_jain> | ||||
| Component: | Tools / Tests | Assignee: | Aakash Jain <aakash_jain> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | aakash_jain, ap, jbedard, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | Other | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Aakash Jain
2020-02-20 11:22:10 PST
Created attachment 391315 [details]
Patch
Comment on attachment 391315 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=391315&action=review > Tools/BuildSlaveSupport/ews-build/steps.py:452 > + flags = [{'name': 'commit-queue', 'status': '-'}] Nit: Any reason to keep this on it's own line? It's only used on line 454, not sure that it makes things more clear. Comment on attachment 391315 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=391315&action=review >> Tools/BuildSlaveSupport/ews-build/steps.py:452 >> + flags = [{'name': 'commit-queue', 'status': '-'}] > > Nit: Any reason to keep this on it's own line? It's only used on line 454, not sure that it makes things more clear. just for readability. line 454 would have become too long and hard to read with this info in it. Committed r257147: <https://trac.webkit.org/changeset/257147> |