| Summary: | [Web Animations] Repeated animations on pseudo elements will fail to run after a while | ||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Simon Fraser (smfr) <simon.fraser> | ||||||||||||||
| Component: | Animations | Assignee: | Simon Fraser (smfr) <simon.fraser> | ||||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||||
| Severity: | Normal | CC: | cdumez, cmarcelo, commit-queue, dbates, dino, esprehn+autocc, ews-watchlist, glenn, graouts, kangil.han, koivisto, kondapallykalyan, pdr, rniwa, simon.fraser, tyls.alexandr, webkit-bug-importer, zalan | ||||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||||
| Hardware: | Unspecified | ||||||||||||||||
| OS: | Unspecified | ||||||||||||||||
| Attachments: |
|
||||||||||||||||
|
Description
Simon Fraser (smfr)
2020-02-19 21:15:18 PST
Created attachment 391255 [details]
Patch
Comment on attachment 391255 [details]
Patch
Needs a test.
The assertions appear to be incorrect because there's a call to timeline->elementWasRemoved() from RenderTreeUpdater::tearDownRenderers() which is not about Element destruction. Which means I don't know when it's OK to call m_elementToCSSAnimationsCreatedByMarkupMap.remove(). Yeah, that doesn't make logical sense though may work in practice. I guess the idea is to do a full cleanup. It is only called when renderTreeBeingDestroyed() and that is only set during document destruction and when entering b/f cache. The latter case is suspicious but might be fine. Created attachment 391357 [details]
Patch
Comment on attachment 391357 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=391357&action=review > Source/WebCore/animation/AnimationTimeline.cpp:227 > +void AnimationTimeline::willDestoryRendererForElement(Element& element) destroy typo Created attachment 391379 [details]
Patch
Created attachment 391380 [details]
Patch
Created attachment 391381 [details]
Patch
Created attachment 391398 [details]
Patch
Comment on attachment 391398 [details] Patch Clearing flags on attachment: 391398 Committed r257138: <https://trac.webkit.org/changeset/257138> *** Bug 213547 has been marked as a duplicate of this bug. *** |