| Summary: | Crash in Page::updateRendering when document has no domWindow | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Sunny He <sunny_he> | ||||||
| Component: | Layout and Rendering | Assignee: | Nobody <webkit-unassigned> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | bfulgham, cdumez, commit-queue, rniwa, sabouhallawa, simon.fraser, webkit-bug-importer, zalan | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Sunny He
2020-02-19 17:03:30 PST
Created attachment 391223 [details]
Patch
Comment on attachment 391223 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=391223&action=review > Source/WebCore/page/Page.cpp:1334 > + if (document.domWindow()) { Can we use an early return instead? Comment on attachment 391223 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=391223&action=review >> Source/WebCore/page/Page.cpp:1334 >> + if (document.domWindow()) { > > Can we use an early return instead? Should this be in forEachDocument()? Is there a reason to run any rendering update step for a document which does not have a window? (In reply to Said Abou-Hallawa from comment #3) > Comment on attachment 391223 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=391223&action=review > > >> Source/WebCore/page/Page.cpp:1334 > >> + if (document.domWindow()) { > > > > Can we use an early return instead? > > Should this be in forEachDocument()? Is there a reason to run any rendering > update step for a document which does not have a window? I don’t think we want to do that there because it’s used in other places than Page::updateRendering. Created attachment 391365 [details]
Patch
The commit-queue encountered the following flaky tests while processing attachment 391365 [details]: editing/spelling/spellcheck-input-search-crash.html bug 207995 (authors: arv@chromium.org, g.czajkowski@samsung.com, mark.lam@apple.com, and morrita@google.com) fetch/fetch-worker-crash.html bug 187257 (author: youennf@gmail.com) The commit-queue is continuing to process your patch. Comment on attachment 391365 [details] Patch Clearing flags on attachment: 391365 Committed r257123: <https://trac.webkit.org/changeset/257123> All reviewed patches have been landed. Closing bug. |