| Summary: | [LFC][Floats] FloatingContext::constraints should be able to handle empty candidate ranges (points) | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | zalan <zalan> | ||||||
| Component: | Layout and Rendering | Assignee: | zalan <zalan> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | bfulgham, commit-queue, koivisto, simon.fraser, webkit-bug-importer, zalan | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
zalan
2020-02-19 08:25:11 PST
Created attachment 391165 [details]
Patch
Comment on attachment 391165 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=391165&action=review > Source/WebCore/layout/floats/FloatingContext.cpp:308 > + return floatBoxRect.top() <= adjustedCandidateTop && floatBoxRect.bottom() > adjustedCandidateTop; > + return !(floatBoxRect.top() >= adjustedCandidateBottom || floatBoxRect.bottom() <= adjustedCandidateTop); The difference between these would be clearer if the logic was the same way round (that is no !) (In reply to Antti Koivisto from comment #3) > Comment on attachment 391165 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=391165&action=review > > > Source/WebCore/layout/floats/FloatingContext.cpp:308 > > + return floatBoxRect.top() <= adjustedCandidateTop && floatBoxRect.bottom() > adjustedCandidateTop; > > + return !(floatBoxRect.top() >= adjustedCandidateBottom || floatBoxRect.bottom() <= adjustedCandidateTop); > > The difference between these would be clearer if the logic was the same way > round (that is no !) sure. Created attachment 391173 [details]
Patch
Comment on attachment 391173 [details] Patch Clearing flags on attachment: 391173 Committed r256928: <https://trac.webkit.org/changeset/256928> All reviewed patches have been landed. Closing bug. |