Bug 207930

Summary: [Curl] Simplify Cookie class.
Product: WebKit Reporter: Takashi Komori <takashi.komori>
Component: PlatformAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, Basuke.Suzuki, chris.reid, commit-queue, don.olmstead, ews-watchlist, galpeter, gyuyoung.kim, Hironori.Fujii, pfeldman, ross.kirsling, ryuan.choi, sergio, stephan.szabo, takashi.komori, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Remove redundant CookieJarCurl.cpp
none
Patch
none
Patch none

Description Takashi Komori 2020-02-19 01:26:18 PST
In this ticket we will remove redundant implementation in curl Cookie classes.
Comment 1 Takashi Komori 2020-02-19 01:36:59 PST
Created attachment 391148 [details]
Remove redundant CookieJarCurl.cpp
Comment 2 Basuke Suzuki 2020-02-19 10:23:45 PST
Comment on attachment 391148 [details]
Remove redundant CookieJarCurl.cpp

This is informal review: Please add a simple description of this fix. AFAIK, Curl implementation has an abstraction of cookie backend such as file-based, sqlite-based. This is a left over of those abstraction when file-based implementation was removed.
Comment 3 Takashi Komori 2020-02-19 23:16:07 PST
Created attachment 391265 [details]
Patch
Comment 4 Takashi Komori 2020-02-19 23:47:14 PST
Created attachment 391266 [details]
Patch
Comment 5 WebKit Commit Bot 2020-02-20 12:06:58 PST
Comment on attachment 391266 [details]
Patch

Clearing flags on attachment: 391266

Committed r257078: <https://trac.webkit.org/changeset/257078>
Comment 6 WebKit Commit Bot 2020-02-20 12:07:00 PST
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2020-02-20 12:07:17 PST
<rdar://problem/59638605>