| Summary: | Expand WKRemoteObjectCoder supported POD types to encode NSURLResponse types | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Alex Christensen <achristensen> | ||||
| Component: | New Bugs | Assignee: | Alex Christensen <achristensen> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | bweinstein, cdumez, thorton, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Alex Christensen
2020-02-18 15:00:03 PST
Created attachment 391097 [details]
Patch
Comment on attachment 391097 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=391097&action=review > Source/WebKit/Shared/API/Cocoa/WKRemoteObjectCoder.mm:153 > + case 'S': { Can these two cases be the same? case ’s’: case ’S’: … > Source/WebKit/Shared/API/Cocoa/WKRemoteObjectCoder.mm:366 > + // char Nit: // unsigned char.. Comment on attachment 391097 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=391097&action=review >> Source/WebKit/Shared/API/Cocoa/WKRemoteObjectCoder.mm:153 >> + case 'S': { > > Can these two cases be the same? > > case ’s’: > case ’S’: > … No, but one of my "short value;" should be "unsigned short value;" Will fix when landing. |