| Summary: | results.webkit.org: Correctly report JSC tests for windows | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Jonathan Bedard <jbedard> | ||||||
| Component: | Tools / Tests | Assignee: | Jonathan Bedard <jbedard> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | aakash_jain, commit-queue, dbates, ews-watchlist, webkit-bug-importer, zhifei_fang | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Jonathan Bedard
2020-02-18 14:05:44 PST
Created attachment 391092 [details]
Patch
Comment on attachment 391092 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=391092&action=review rs=me > Tools/Scripts/webkitdirs.pm:1372 > + $versionString =~ /(\d+)\.(\d+)\.(\d+)/; what does versionString looks like on windows? (In reply to Aakash Jain from comment #2) > Comment on attachment 391092 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=391092&action=review > > rs=me > > > Tools/Scripts/webkitdirs.pm:1372 > > + $versionString =~ /(\d+)\.(\d+)\.(\d+)/; > > what does versionString looks like on windows? 10.0.12345 Obviously that last part isn't accurate, but it is a large 4-5 digit number. Created attachment 391160 [details]
Patch for landing
The commit-queue encountered the following flaky tests while processing attachment 391160 [details]: http/tests/security/contentSecurityPolicy/report-status-code-zero-when-using-https.html bug 197297 (author: dbates@webkit.org) The commit-queue is continuing to process your patch. Comment on attachment 391160 [details] Patch for landing Clearing flags on attachment: 391160 Committed r256920: <https://trac.webkit.org/changeset/256920> All reviewed patches have been landed. Closing bug. Committed r257058: <https://trac.webkit.org/changeset/257058> |