Bug 207906

Summary:

Build failure on ppc64le if __unix is undefined

Product:

WebKit

Reporter:

Mike Gorse <mgorse>

Component:

bmalloc

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, ggaren, mgorse, webkit-bug-importer, ysuzuki

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

OS:

Linux

Attachments:

Description	Flags
Patch.	none

Description Mike Gorse 2020-02-18 13:05:46 PST

I'm getting a build failure building webkitgtk for ppc64le on SLE 15 (gcc 7.5.0).
__unix is undefined when building with -std=c++1z (but only on ppc64le, apparently), so BOS_UNIX doesn't get defined, leading to some headers not being included later. __unix__ is defined.

Comment 1 Mike Gorse 2020-02-18 13:18:47 PST

Created attachment 391081 [details]
Patch.

Comment 2 Yusuke Suzuki 2020-03-09 00:18:49 PDT

Comment on attachment 391081 [details]
Patch.

r=me

Comment 3 WebKit Commit Bot 2020-03-09 08:25:23 PDT

Comment on attachment 391081 [details]
Patch.

Clearing flags on attachment: 391081

Committed r258142: <https://trac.webkit.org/changeset/258142>

Comment 4 WebKit Commit Bot 2020-03-09 08:25:24 PDT

All reviewed patches have been landed.  Closing bug.

Comment 5 Radar WebKit Bug Importer 2020-03-09 08:26:19 PDT

<rdar://problem/60223932>