| Summary: | Add an os_log PrintStream | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Keith Miller <keith_miller> | ||||||||||||
| Component: | New Bugs | Assignee: | Keith Miller <keith_miller> | ||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||
| Severity: | Normal | CC: | annulen, benjamin, cdumez, cmarcelo, commit-queue, dbates, ews-watchlist, gyuyoung.kim, mark.lam, msaboff, ryuan.choi, saam, sergio, tzagallo, webkit-bug-importer | ||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||
| Hardware: | Unspecified | ||||||||||||||
| OS: | Unspecified | ||||||||||||||
| Attachments: |
|
||||||||||||||
|
Description
Keith Miller
2020-02-18 10:51:16 PST
Created attachment 391066 [details]
Patch
Created attachment 391068 [details]
Patch
Comment on attachment 391068 [details]
Patch
Patch missing files.
Created attachment 391069 [details]
Patch
Created attachment 391077 [details]
Patch
Comment on attachment 391077 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=391077&action=review r=me with JSC options added. > Source/JavaScriptCore/jsc.cpp:2941 > +#if OS(DARWIN) > + setDataFile(OSLogPrintStream::open("com.apple.JavaScriptCore", "DataLog", OS_LOG_TYPE_INFO)); > +#else Please add a JSC option to invoke this so that we can also enable this os logging for the WebProcess, or whatever process is using JSC. Created attachment 391127 [details]
Patch for landing
Comment on attachment 391127 [details] Patch for landing View in context: https://bugs.webkit.org/attachment.cgi?id=391127&action=review > Source/JavaScriptCore/runtime/Options.cpp:621 > + RELEASE_ASSERT(useOSLog()); Shouldn't this be Options::useOSLog()? The commit-queue encountered the following flaky tests while processing attachment 391127 [details]: editing/spelling/spellcheck-async-remove-frame.html bug 158401 (authors: morrita@google.com, rniwa@webkit.org, and tony@chromium.org) The commit-queue is continuing to process your patch. The commit-queue encountered the following flaky tests while processing attachment 391127 [details]: imported/w3c/web-platform-tests/IndexedDB/fire-success-event-exception.html bug 206554 (authors: shvaikalesh@gmail.com and youennf@gmail.com) editing/spelling/spellcheck-attribute.html bug 206178 (authors: g.czajkowski@samsung.com, mark.lam@apple.com, and rniwa@webkit.org) The commit-queue is continuing to process your patch. The commit-queue encountered the following flaky tests while processing attachment 391127 [details]: editing/spelling/spellcheck-attribute.html bug 206178 (authors: g.czajkowski@samsung.com, mark.lam@apple.com, and rniwa@webkit.org) The commit-queue is continuing to process your patch. Comment on attachment 391127 [details] Patch for landing Clearing flags on attachment: 391127 Committed r256910: <https://trac.webkit.org/changeset/256910> All reviewed patches have been landed. Closing bug. |