Bug 207885

Summary: [ARM] Build failure on arm due to invalid use of incomplete type 'class WebCore::ImageData' in FEBlendNEON.h
Product: WebKit Reporter: Chris Lord <clord>
Component: ImagesAssignee: Chris Lord <clord>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, clopez, commit-queue, darin, sabouhallawa, simon.fraser, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Chris Lord
Reported 2020-02-18 03:56:34 PST
> | In file included from /home/cwiiis/Projects/perf-browser-bsp/builds/raspberrypi3-mesa-browsers/tmp/work/cortexa7t2hf-neon-vfpv4-poky-linux-gnueabi/wpewebkit/nightly-AUTOINC+dc3104c055-r0/git/Source/WebCore/platform/graphics/filters/FEBlend.cpp:28, > | from DerivedSources/WebCore/unified-sources/UnifiedSource-3c72abbe-28.cpp:1: > | /home/cwiiis/Projects/perf-browser-bsp/builds/raspberrypi3-mesa-browsers/tmp/work/cortexa7t2hf-neon-vfpv4-poky-linux-gnueabi/wpewebkit/nightly-AUTOINC+dc3104c055-r0/git/Source/WebCore/platform/graphics/cpu/arm/filters/FEBlendNEON.h: In member function 'virtual void WebCore::FEBlend::platformApplySoftware()': > | /home/cwiiis/Projects/perf-browser-bsp/builds/raspberrypi3-mesa-browsers/tmp/work/cortexa7t2hf-neon-vfpv4-poky-linux-gnueabi/wpewebkit/nightly-AUTOINC+dc3104c055-r0/git/Source/WebCore/platform/graphics/cpu/arm/filters/FEBlendNEON.h:115:52: error: invalid use of incomplete type 'class WebCore::ImageData' > | 115 | auto* dstPixelArray = imageResult ? imageResult->data() : nullptr; > | | ^~ > | In file included from /home/cwiiis/Projects/perf-browser-bsp/builds/raspberrypi3-mesa-browsers/tmp/work/cortexa7t2hf-neon-vfpv4-poky-linux-gnueabi/wpewebkit/nightly-AUTOINC+dc3104c055-r0/git/Source/WebCore/platform/graphics/filters/FEBlend.h:25, > | from /home/cwiiis/Projects/perf-browser-bsp/builds/raspberrypi3-mesa-browsers/tmp/work/cortexa7t2hf-neon-vfpv4-poky-linux-gnueabi/wpewebkit/nightly-AUTOINC+dc3104c055-r0/git/Source/WebCore/platform/graphics/filters/FEBlend.cpp:26, > | from DerivedSources/WebCore/unified-sources/UnifiedSource-3c72abbe-28.cpp:1: I don't know what the best fix is, but including ImageData.h in FEBlendNEON.h does fix it, so I'll attach that patch.
Attachments
Patch (1.27 KB, patch)
2020-02-18 03:59 PST, Chris Lord 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Chris Lord
Comment 1 2020-02-18 03:59:31 PST
Created attachment 391039 [details] Patch
WebKit Commit Bot
Comment 2 2020-02-18 06:15:45 PST
Comment on attachment 391039 [details] Patch Clearing flags on attachment: 391039 Committed r256825: <https://trac.webkit.org/changeset/256825>
WebKit Commit Bot
Comment 3 2020-02-18 06:15:47 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 4 2020-02-18 06:16:13 PST
<rdar://problem/59547710>
Said Abou-Hallawa
Comment 5 2020-02-18 08:40:52 PST
(In reply to Chris Lord from comment #0) > > | In file included from /home/cwiiis/Projects/perf-browser-bsp/builds/raspberrypi3-mesa-browsers/tmp/work/cortexa7t2hf-neon-vfpv4-poky-linux-gnueabi/wpewebkit/nightly-AUTOINC+dc3104c055-r0/git/Source/WebCore/platform/graphics/filters/FEBlend.cpp:28, > > | from DerivedSources/WebCore/unified-sources/UnifiedSource-3c72abbe-28.cpp:1: > > | /home/cwiiis/Projects/perf-browser-bsp/builds/raspberrypi3-mesa-browsers/tmp/work/cortexa7t2hf-neon-vfpv4-poky-linux-gnueabi/wpewebkit/nightly-AUTOINC+dc3104c055-r0/git/Source/WebCore/platform/graphics/cpu/arm/filters/FEBlendNEON.h: In member function 'virtual void WebCore::FEBlend::platformApplySoftware()': > > | /home/cwiiis/Projects/perf-browser-bsp/builds/raspberrypi3-mesa-browsers/tmp/work/cortexa7t2hf-neon-vfpv4-poky-linux-gnueabi/wpewebkit/nightly-AUTOINC+dc3104c055-r0/git/Source/WebCore/platform/graphics/cpu/arm/filters/FEBlendNEON.h:115:52: error: invalid use of incomplete type 'class WebCore::ImageData' > > | 115 | auto* dstPixelArray = imageResult ? imageResult->data() : nullptr; > > | | ^~ > > | In file included from /home/cwiiis/Projects/perf-browser-bsp/builds/raspberrypi3-mesa-browsers/tmp/work/cortexa7t2hf-neon-vfpv4-poky-linux-gnueabi/wpewebkit/nightly-AUTOINC+dc3104c055-r0/git/Source/WebCore/platform/graphics/filters/FEBlend.h:25, > > | from /home/cwiiis/Projects/perf-browser-bsp/builds/raspberrypi3-mesa-browsers/tmp/work/cortexa7t2hf-neon-vfpv4-poky-linux-gnueabi/wpewebkit/nightly-AUTOINC+dc3104c055-r0/git/Source/WebCore/platform/graphics/filters/FEBlend.cpp:26, > > | from DerivedSources/WebCore/unified-sources/UnifiedSource-3c72abbe-28.cpp:1: > > I don't know what the best fix is, but including ImageData.h in > FEBlendNEON.h does fix it, so I'll attach that patch. Yes this is the right fix. It is caused by the unified sources compilation. Thanks for taking care of this failure.
Note You need to log in before you can comment on or make changes to this bug.