| Summary: | [ARM] Build failure on arm due to invalid use of incomplete type 'class WebCore::ImageData' in FEBlendNEON.h | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Chris Lord <clord> | ||||
| Component: | Images | Assignee: | Chris Lord <clord> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | achristensen, clopez, commit-queue, darin, sabouhallawa, simon.fraser, thorton, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
Created attachment 391039 [details]
Patch
Comment on attachment 391039 [details] Patch Clearing flags on attachment: 391039 Committed r256825: <https://trac.webkit.org/changeset/256825> All reviewed patches have been landed. Closing bug. (In reply to Chris Lord from comment #0) > > | In file included from /home/cwiiis/Projects/perf-browser-bsp/builds/raspberrypi3-mesa-browsers/tmp/work/cortexa7t2hf-neon-vfpv4-poky-linux-gnueabi/wpewebkit/nightly-AUTOINC+dc3104c055-r0/git/Source/WebCore/platform/graphics/filters/FEBlend.cpp:28, > > | from DerivedSources/WebCore/unified-sources/UnifiedSource-3c72abbe-28.cpp:1: > > | /home/cwiiis/Projects/perf-browser-bsp/builds/raspberrypi3-mesa-browsers/tmp/work/cortexa7t2hf-neon-vfpv4-poky-linux-gnueabi/wpewebkit/nightly-AUTOINC+dc3104c055-r0/git/Source/WebCore/platform/graphics/cpu/arm/filters/FEBlendNEON.h: In member function 'virtual void WebCore::FEBlend::platformApplySoftware()': > > | /home/cwiiis/Projects/perf-browser-bsp/builds/raspberrypi3-mesa-browsers/tmp/work/cortexa7t2hf-neon-vfpv4-poky-linux-gnueabi/wpewebkit/nightly-AUTOINC+dc3104c055-r0/git/Source/WebCore/platform/graphics/cpu/arm/filters/FEBlendNEON.h:115:52: error: invalid use of incomplete type 'class WebCore::ImageData' > > | 115 | auto* dstPixelArray = imageResult ? imageResult->data() : nullptr; > > | | ^~ > > | In file included from /home/cwiiis/Projects/perf-browser-bsp/builds/raspberrypi3-mesa-browsers/tmp/work/cortexa7t2hf-neon-vfpv4-poky-linux-gnueabi/wpewebkit/nightly-AUTOINC+dc3104c055-r0/git/Source/WebCore/platform/graphics/filters/FEBlend.h:25, > > | from /home/cwiiis/Projects/perf-browser-bsp/builds/raspberrypi3-mesa-browsers/tmp/work/cortexa7t2hf-neon-vfpv4-poky-linux-gnueabi/wpewebkit/nightly-AUTOINC+dc3104c055-r0/git/Source/WebCore/platform/graphics/filters/FEBlend.cpp:26, > > | from DerivedSources/WebCore/unified-sources/UnifiedSource-3c72abbe-28.cpp:1: > > I don't know what the best fix is, but including ImageData.h in > FEBlendNEON.h does fix it, so I'll attach that patch. Yes this is the right fix. It is caused by the unified sources compilation. Thanks for taking care of this failure. |
> | In file included from /home/cwiiis/Projects/perf-browser-bsp/builds/raspberrypi3-mesa-browsers/tmp/work/cortexa7t2hf-neon-vfpv4-poky-linux-gnueabi/wpewebkit/nightly-AUTOINC+dc3104c055-r0/git/Source/WebCore/platform/graphics/filters/FEBlend.cpp:28, > | from DerivedSources/WebCore/unified-sources/UnifiedSource-3c72abbe-28.cpp:1: > | /home/cwiiis/Projects/perf-browser-bsp/builds/raspberrypi3-mesa-browsers/tmp/work/cortexa7t2hf-neon-vfpv4-poky-linux-gnueabi/wpewebkit/nightly-AUTOINC+dc3104c055-r0/git/Source/WebCore/platform/graphics/cpu/arm/filters/FEBlendNEON.h: In member function 'virtual void WebCore::FEBlend::platformApplySoftware()': > | /home/cwiiis/Projects/perf-browser-bsp/builds/raspberrypi3-mesa-browsers/tmp/work/cortexa7t2hf-neon-vfpv4-poky-linux-gnueabi/wpewebkit/nightly-AUTOINC+dc3104c055-r0/git/Source/WebCore/platform/graphics/cpu/arm/filters/FEBlendNEON.h:115:52: error: invalid use of incomplete type 'class WebCore::ImageData' > | 115 | auto* dstPixelArray = imageResult ? imageResult->data() : nullptr; > | | ^~ > | In file included from /home/cwiiis/Projects/perf-browser-bsp/builds/raspberrypi3-mesa-browsers/tmp/work/cortexa7t2hf-neon-vfpv4-poky-linux-gnueabi/wpewebkit/nightly-AUTOINC+dc3104c055-r0/git/Source/WebCore/platform/graphics/filters/FEBlend.h:25, > | from /home/cwiiis/Projects/perf-browser-bsp/builds/raspberrypi3-mesa-browsers/tmp/work/cortexa7t2hf-neon-vfpv4-poky-linux-gnueabi/wpewebkit/nightly-AUTOINC+dc3104c055-r0/git/Source/WebCore/platform/graphics/filters/FEBlend.cpp:26, > | from DerivedSources/WebCore/unified-sources/UnifiedSource-3c72abbe-28.cpp:1: I don't know what the best fix is, but including ImageData.h in FEBlendNEON.h does fix it, so I'll attach that patch.