Bug 207879

Summary:

[LFC][TreeBuilding] Take createLineBreakBox's return value

Product:

WebKit

Reporter:

zalan <zalan>

Component:

Layout and Rendering

Assignee:

zalan <zalan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, commit-queue, koivisto, simon.fraser, webkit-bug-importer, zalan

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description zalan 2020-02-17 20:59:54 PST

childLayoutBox = &createLineBreakBox(downcast<RenderLineBreak>(childRenderer).isWBR(), WTFMove(clonedStyle))

Comment 1 Radar WebKit Bug Importer 2020-02-17 21:00:18 PST

<rdar://problem/59537585>

Comment 2 zalan 2020-02-17 21:07:04 PST

Created attachment 391027 [details]
Patch

Comment 3 Antti Koivisto 2020-02-18 02:45:09 PST

Comment on attachment 391027 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=391027&action=review

> Source/WebCore/layout/layouttree/LayoutTreeBuilder.cpp:216
> -            createLineBreakBox(downcast<RenderLineBreak>(childRenderer).isWBR(), WTFMove(clonedStyle));
> +            childLayoutBox = &createLineBreakBox(downcast<RenderLineBreak>(childRenderer).isWBR(), WTFMove(clonedStyle));

lol

Comment 4 WebKit Commit Bot 2020-02-18 06:57:58 PST

Comment on attachment 391027 [details]
Patch

Clearing flags on attachment: 391027

Committed r256827: <https://trac.webkit.org/changeset/256827>

Comment 5 WebKit Commit Bot 2020-02-18 06:58:00 PST

All reviewed patches have been landed.  Closing bug.

Comment 6 zalan 2020-02-18 07:18:35 PST

(In reply to Antti Koivisto from comment #3)
> Comment on attachment 391027 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=391027&action=review
> 
> > Source/WebCore/layout/layouttree/LayoutTreeBuilder.cpp:216
> > -            createLineBreakBox(downcast<RenderLineBreak>(childRenderer).isWBR(), WTFMove(clonedStyle));
> > +            childLayoutBox = &createLineBreakBox(downcast<RenderLineBreak>(childRenderer).isWBR(), WTFMove(clonedStyle));
> 
> lol
exactly my thoughts.