| Summary: | Move from "layer flush" terminology to "rendering update" | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Simon Fraser (smfr) <simon.fraser> | ||||||||||
| Component: | New Bugs | Assignee: | Simon Fraser (smfr) <simon.fraser> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | annulen, benjamin, cdumez, cmarcelo, commit-queue, dbates, esprehn+autocc, ews-watchlist, gyuyoung.kim, japhet, kangil.han, koivisto, luiz, noam, ryuan.choi, sabouhallawa, sergio, simon.fraser, thorton, webkit-bug-importer, zeno | ||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||
| Version: | WebKit Nightly Build | ||||||||||||
| Hardware: | Unspecified | ||||||||||||
| OS: | Unspecified | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Simon Fraser (smfr)
2020-02-17 16:44:19 PST
Created attachment 391002 [details]
Patch
Comment on attachment 391002 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=391002&action=review > Source/WebCore/page/ChromeClient.h:342 > + virtual bool adjustRenderUpdateThrottling(OptionSet<RenderingUpdateThrottleState>) { return false; } should this be an -ing? > Source/WebKit/WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeDrawingArea.h:159 > + bool m_nextRenderingUpdateIsImmediate { false }; If we're changing the name, can we change it to something less mysterious? Created attachment 391010 [details]
Patch
Created attachment 391020 [details]
Patch
Created attachment 391032 [details]
Patch
Comment on attachment 391032 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=391032&action=review > Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/DrawingAreaCoordinatedGraphics.cpp:211 > + } > } Weird indentation. Is there some terminology confusion here with the HTML concept of "rendering update"? To reach visually non-empty state we need to update layout without doing any layer flushes. Should there be a concept of "visual rendering update" or similar? (In reply to Antti Koivisto from comment #7) > Is there some terminology confusion here with the HTML concept of "rendering > update"? Perhaps, but I was trying to match this terminology on purpose. > To reach visually non-empty state we need to update layout without > doing any layer flushes. Should there be a concept of "visual rendering > update" or similar? Probably! Comment on attachment 391032 [details] Patch Clearing flags on attachment: 391032 Committed r256834: <https://trac.webkit.org/changeset/256834> |