| Summary: | [GTK][WPE] Set ccache as compiler launcher, add opt-in sccache support | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Philippe Normand <pnormand> | ||||||
| Component: | CMake | Assignee: | Philippe Normand <pnormand> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | annulen, clopez, ews-watchlist, gyuyoung.kim, ryuan.choi, sergio | ||||||
| Priority: | P2 | ||||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=208007 | ||||||||
| Attachments: |
|
||||||||
|
Description
Philippe Normand
2020-02-17 06:16:24 PST
Created attachment 390916 [details]
Patch
Comment on attachment 390916 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=390916&action=review > Source/cmake/WebKitCCache.cmake:6 > set_property(GLOBAL PROPERTY RULE_LAUNCH_COMPILE ${CMAKE_SOURCE_DIR}/Tools/ccache/ccache-wrapper) I don't like much the idea of calling a bash wrapper instead of ccache directly just to export two environment variables. I think exporting this environment variables can be done also by CMake and we can call ccache directly avoiding the overhead of calling as extra env+bash for each compilation unit. Comment on attachment 390916 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=390916&action=review >> Source/cmake/WebKitCCache.cmake:6 >> set_property(GLOBAL PROPERTY RULE_LAUNCH_COMPILE ${CMAKE_SOURCE_DIR}/Tools/ccache/ccache-wrapper) > > I don't like much the idea of calling a bash wrapper instead of ccache directly just to export two environment variables. > I think exporting this environment variables can be done also by CMake and we can call ccache directly avoiding the overhead of calling as extra env+bash for each compilation unit. OK then I won't touch this Mac-specific code. Actually I don't think we need those vars for GTK/WPE. Besides, the ccache-wrapper is called by the "clang-wrapper"... Created attachment 390924 [details]
Patch
Committed r256917: <https://trac.webkit.org/changeset/256917> |