Bug 207837

Summary: [macOS] Add trace points for layer flush runloop observer
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: Page LoadingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: beidson, benjamin, cdumez, cmarcelo, commit-queue, dbates, ews-watchlist, nham, sam, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
none
patch
none
patch
sam: review+
patch none

Description Antti Koivisto 2020-02-17 05:03:46 PST 
Add trace points to see how much layer flushes get delayed.
Comment 1 Antti Koivisto 2020-02-17 05:19:50 PST 
Created attachment 390914 [details]
patch
Comment 2 Antti Koivisto 2020-02-17 05:25:59 PST 
Created attachment 390915 [details]
patch
Comment 3 Antti Koivisto 2020-02-17 06:51:42 PST 
Created attachment 390917 [details]
patch
Comment 4 Sam Weinig 2020-02-17 07:54:56 PST 
Comment on attachment 390917 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=390917&action=review

> Source/WTF/ChangeLog:3
> +        [MacOS] Add trace points for layer flush runloop observer

lowercase m in [macOS].

> Source/WTF/wtf/SystemTracing.h:108
> +    LayerTreeFreezeStart,
> +    LayerTreeFreezeEnd,

Should mention these in the change log as well.
Comment 5 Antti Koivisto 2020-02-17 08:00:51 PST 
Created attachment 390919 [details]
patch
Comment 6 Antti Koivisto 2020-02-17 08:01:32 PST 
> Should mention these in the change log as well.

It was mentioned in WebKit changelog (where the other comments were).
Comment 7 WebKit Commit Bot 2020-02-17 08:45:33 PST 
Comment on attachment 390919 [details]
patch

Clearing flags on attachment: 390919

Committed r256736: <https://trac.webkit.org/changeset/256736>
Comment 8 WebKit Commit Bot 2020-02-17 08:45:35 PST 
All reviewed patches have been landed.  Closing bug.
Comment 9 Radar WebKit Bug Importer 2020-02-17 08:46:14 PST 
<rdar://problem/59512045>