Bug 207832

Summary: [LFC][Out-of-flow] FormattingContext::computeOutOfFlowHorizontalGeometry needs verticalConstraints
Product: WebKit Reporter: zalan <zalan>
Component: Layout and RenderingAssignee: zalan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, dino, koivisto, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description zalan 2020-02-16 20:36:02 PST 
while figuring out computedContentHeight through inlineReplacedWidthAndMargin
Comment 1 Radar WebKit Bug Importer 2020-02-16 20:36:25 PST 
<rdar://problem/59499844>
Comment 2 zalan 2020-02-16 21:08:06 PST 
Created attachment 390898 [details]
Patch
Comment 3 Dean Jackson 2020-02-17 09:30:09 PST 
Comment on attachment 390898 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=390898&action=review

> Source/WebCore/layout/inlineformatting/InlineFormattingContext.cpp:286
> +        contentWidthAndMargin = geometry().inlineReplacedWidthAndMargin(downcast<ReplacedBox>(layoutBox), horizontalConstraints, { }, usedWidth);

Shouldn't the {}s be nullopts?
Comment 4 WebKit Commit Bot 2020-02-17 12:29:15 PST 
Comment on attachment 390898 [details]
Patch

Clearing flags on attachment: 390898

Committed r256760: <https://trac.webkit.org/changeset/256760>
Comment 5 WebKit Commit Bot 2020-02-17 12:29:16 PST 
All reviewed patches have been landed.  Closing bug.
Comment 6 zalan 2020-02-17 13:11:11 PST 
(In reply to Dean Jackson from comment #3)
> Comment on attachment 390898 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=390898&action=review
> 
> > Source/WebCore/layout/inlineformatting/InlineFormattingContext.cpp:286
> > +        contentWidthAndMargin = geometry().inlineReplacedWidthAndMargin(downcast<ReplacedBox>(layoutBox), horizontalConstraints, { }, usedWidth);
> 
> Shouldn't the {}s be nullopts?
{} is nullopt when the type is WTF::Optional.