Bug 207819

Summary: Web Inspector: Add "outline focused element" debug setting
Product: WebKit Reporter: Nikita Vasilyev <nvasilyev>
Component: Web InspectorAssignee: Nikita Vasilyev <nvasilyev>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, hi, inspector-bugzilla-changes, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 208217    
Attachments:
Description Flags
Patch
none
[Image] With patch applied none

Description Nikita Vasilyev 2020-02-15 17:37:33 PST 
When debugging accessibility issues of Web Inspector, it's helpful to know what element is focused. Many elements have "outline: none" and no clear indication what's focused.

Add a debug setting to show a bright outline for all focused elements.
Comment 1 Radar WebKit Bug Importer 2020-02-15 17:37:45 PST 
<rdar://problem/59489993>
Comment 2 Nikita Vasilyev 2020-02-15 17:45:39 PST 
Created attachment 390877 [details]
Patch
Comment 3 Nikita Vasilyev 2020-02-15 17:49:19 PST 
Created attachment 390879 [details]
[Image] With patch applied
Comment 4 WebKit Commit Bot 2020-02-17 16:26:56 PST 
Comment on attachment 390877 [details]
Patch

Clearing flags on attachment: 390877

Committed r256788: <https://trac.webkit.org/changeset/256788>
Comment 5 WebKit Commit Bot 2020-02-17 16:26:57 PST 
All reviewed patches have been landed.  Closing bug.
Comment 6 Devin Rousso 2020-02-25 13:57:06 PST 
Comment on attachment 390877 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=390877&action=review

> Source/WebInspectorUI/UserInterface/Base/Main.js:568
> +    function setFocusDebugOutline() {

This should really exist inside 'Source/WebInspectorUI/UserInterface/Debug/Bootstrap.js' so we don't ship it when it's not going to be usable.

> Source/WebInspectorUI/UserInterface/Views/Main.css:124
> +body.focus-debug *:focus {

This should really exist inside 'Source/WebInspectorUI/UserInterface/Debug/Bootstrap.css' (which we should create) so we don't ship it when it's not going to be usable.