Bug 207814

Summary:

[LFC][BFC] ConstraintsPair is only needed for the pre-computed vertical position

Product:

WebKit

Reporter:

zalan <zalan>

Component:

Layout and Rendering

Assignee:

zalan <zalan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, koivisto, simon.fraser, webkit-bug-importer, zalan

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none

Description zalan 2020-02-15 05:35:42 PST

After r256099, ConstraintsPair is only need in few functions.

Comment 1 Radar WebKit Bug Importer 2020-02-15 05:36:03 PST

<rdar://problem/59485612>

Comment 2 zalan 2020-02-15 05:39:52 PST

Created attachment 390865 [details]
Patch

Comment 3 Antti Koivisto 2020-02-15 06:18:33 PST

Comment on attachment 390865 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=390865&action=review

> Source/WebCore/ChangeLog:9
> +        After r256099 (Pre-compute vertical position only when we really need it), ConstraintsPair<> is only

Can it be removed entirely?

Comment 4 zalan 2020-02-15 07:22:36 PST

Created attachment 390867 [details]
Patch

Comment 5 zalan 2020-02-15 13:54:58 PST

Created attachment 390871 [details]
Patch

Comment 6 zalan 2020-02-15 14:01:25 PST

Committed r256704: <https://trac.webkit.org/changeset/256704>

Comment 7 zalan 2020-02-17 13:39:39 PST

(In reply to Antti Koivisto from comment #3)
> Comment on attachment 390865 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=390865&action=review
> 
> > Source/WebCore/ChangeLog:9
> > +        After r256099 (Pre-compute vertical position only when we really need it), ConstraintsPair<> is only
> 
> Can it be removed entirely?
Unfortunately not, some quirk functions (when we pre-compute the vertical position on the ancestors) still need both the root and the containing block values.