| Summary: | Stop using QTKit for rendering WK1 video fullscreen controls | ||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Jer Noble <jer.noble> | ||||||||||||||
| Component: | New Bugs | Assignee: | Jer Noble <jer.noble> | ||||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||||
| Severity: | Normal | CC: | aakash_jain, calvaris, cdumez, commit-queue, eric.carlson, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, jonlee, philipj, sergio, webkit-bug-importer | ||||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||||
| Hardware: | Unspecified | ||||||||||||||||
| OS: | Unspecified | ||||||||||||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=208156 | ||||||||||||||||
| Attachments: |
|
||||||||||||||||
|
Description
Jer Noble
2020-02-14 14:54:58 PST
Created attachment 390828 [details]
Patch
Comment on attachment 390828 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=390828&action=review > Source/WebKitLegacy/mac/ChangeLog:12 > + move the fullscreen winodw to a separate space. This requires subclassing AVPlayerView so that window Created attachment 390931 [details]
Patch
Comment on attachment 390931 [details] Patch Seems to break the build: iOS: PAL/pal/spi/cocoa/AVKitSPI.h:33:33: error: cannot find interface declaration for 'UIResponder', superclass of 'AVPlayerController' https://ews-build.webkit.org/#/builders/23/builds/10800/steps/7/logs/errors macOS: clang: error: no such file or directory: '/Volumes/Data/worker/macOS-Mojave-Release-Build-EWS/build/Source/WebKitLegacy/mac/WebView/WebVideoFullscreenHUDWindowController.mm' https://ews-build.webkit.org/#/builders/33/builds/3067/steps/7/logs/errors Created attachment 390942 [details]
Patch
Created attachment 390957 [details]
Patch
Created attachment 390970 [details]
Patch
Comment on attachment 390970 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=390970&action=review > Source/WebKitLegacy/mac/WebView/WebVideoFullscreenController.mm:193 > +// [[NSNotificationCenter defaultCenter] addObserver:self selector:@selector(applicationDidChangeScreenParameters:) name:NSApplicationDidChangeScreenParametersNotification object:NSApp]; please remove. Created attachment 391468 [details]
Patch for landing
Comment on attachment 391468 [details] Patch for landing Clearing flags on attachment: 391468 Committed r257189: <https://trac.webkit.org/changeset/257189> |