| Summary: | Add WebInspector support to WebKit::WebSocketChannel | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | youenn fablet <youennf> | ||||||||||||
| Component: | WebCore Misc. | Assignee: | youenn fablet <youennf> | ||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||
| Severity: | Normal | CC: | achristensen, annulen, commit-queue, d3sk41, darin, ews-watchlist, gyuyoung.kim, ryuan.choi, sergio, toyoshim, webkit-bug-importer, yutak | ||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||
| Hardware: | Unspecified | ||||||||||||||
| OS: | Unspecified | ||||||||||||||
| Attachments: |
|
||||||||||||||
|
Description
youenn fablet
2020-02-14 14:52:06 PST
Created attachment 390826 [details]
Patch
Created attachment 390827 [details]
Patch
Created attachment 390831 [details]
Patch
Created attachment 390845 [details]
Patch
Comment on attachment 390845 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=390845&action=review > Source/WebCore/Modules/websockets/WebSocketChannelInspector.h:50 > + unsigned long m_progressIdentifier { 0 }; The use of “long” here seems questionable. An unsigned is already 32 bits, just like an unsigned long. > Source/WebKit/WebProcess/Network/WebSocketChannel.cpp:53 > + WebSocketFrame frame(opCode, true, false, true, data, length); Sure seems mysterious, written like this. Created attachment 390936 [details]
Patch for landing
(In reply to Darin Adler from comment #5) > Comment on attachment 390845 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=390845&action=review > > > Source/WebCore/Modules/websockets/WebSocketChannelInspector.h:50 > > + unsigned long m_progressIdentifier { 0 }; Changed it to unsigned. > The use of “long” here seems questionable. An unsigned is already 32 bits, > just like an unsigned long. > > > Source/WebKit/WebProcess/Network/WebSocketChannel.cpp:53 > > + WebSocketFrame frame(opCode, true, false, true, data, length); > > Sure seems mysterious, written like this. Reused the other routine that is indeed clearer. Comment on attachment 390936 [details] Patch for landing Clearing flags on attachment: 390936 Committed r256762: <https://trac.webkit.org/changeset/256762> All reviewed patches have been landed. Closing bug. |