Bug 207794

Summary: Add WebInspector support to WebKit::WebSocketChannel
Product: WebKit Reporter: youenn fablet <youennf>
Component: WebCore Misc.Assignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, annulen, commit-queue, d3sk41, darin, ews-watchlist, gyuyoung.kim, ryuan.choi, sergio, toyoshim, webkit-bug-importer, yutak
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch for landing none

youenn fablet
Reported 2020-02-14 14:52:06 PST
Add WebInspector support to WebKit::WebSocketChannel
Attachments
Patch (22.88 KB, patch)
2020-02-14 14:55 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (22.05 KB, patch)
2020-02-14 14:56 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (23.51 KB, patch)
2020-02-14 16:10 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (22.38 KB, patch)
2020-02-14 17:56 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch for landing (22.06 KB, patch)
2020-02-17 10:41 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2020-02-14 14:55:19 PST
Created attachment 390826 [details] Patch
youenn fablet
Comment 2 2020-02-14 14:56:55 PST
Created attachment 390827 [details] Patch
youenn fablet
Comment 3 2020-02-14 16:10:48 PST
Created attachment 390831 [details] Patch
youenn fablet
Comment 4 2020-02-14 17:56:40 PST
Created attachment 390845 [details] Patch
Darin Adler
Comment 5 2020-02-16 15:54:09 PST
Comment on attachment 390845 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=390845&action=review > Source/WebCore/Modules/websockets/WebSocketChannelInspector.h:50 > + unsigned long m_progressIdentifier { 0 }; The use of “long” here seems questionable. An unsigned is already 32 bits, just like an unsigned long. > Source/WebKit/WebProcess/Network/WebSocketChannel.cpp:53 > + WebSocketFrame frame(opCode, true, false, true, data, length); Sure seems mysterious, written like this.
youenn fablet
Comment 6 2020-02-17 10:41:50 PST
Created attachment 390936 [details] Patch for landing
youenn fablet
Comment 7 2020-02-17 10:47:34 PST
(In reply to Darin Adler from comment #5) > Comment on attachment 390845 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=390845&action=review > > > Source/WebCore/Modules/websockets/WebSocketChannelInspector.h:50 > > + unsigned long m_progressIdentifier { 0 }; Changed it to unsigned. > The use of “long” here seems questionable. An unsigned is already 32 bits, > just like an unsigned long. > > > Source/WebKit/WebProcess/Network/WebSocketChannel.cpp:53 > > + WebSocketFrame frame(opCode, true, false, true, data, length); > > Sure seems mysterious, written like this. Reused the other routine that is indeed clearer.
WebKit Commit Bot
Comment 9 2020-02-17 12:46:48 PST
Comment on attachment 390936 [details] Patch for landing Clearing flags on attachment: 390936 Committed r256762: <https://trac.webkit.org/changeset/256762>
WebKit Commit Bot
Comment 10 2020-02-17 12:46:49 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 11 2020-02-17 12:47:14 PST
<rdar://problem/59522008>
Note You need to log in before you can comment on or make changes to this bug.