Bug 207759

Summary: When updating a subtree of the IsolatedTree, first remove the entire subtree, not just the subtree root.
Product: WebKit Reporter: Andres Gonzalez <andresg_22>
Component: New BugsAssignee: Andres Gonzalez <andresg_22>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, apinheiro, cfleizach, commit-queue, dmazzoni, ews-watchlist, jcraig, jdiggs, samuel_white, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description Andres Gonzalez 2020-02-14 07:03:20 PST 
When updating a subtree of the IsolatedTree, first remove the entire subtree, not just the subtree root.
Comment 1 Andres Gonzalez 2020-02-14 07:28:19 PST 
Created attachment 390764 [details]
Patch
Comment 2 chris fleizach 2020-02-14 08:47:47 PST 
Comment on attachment 390764 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=390764&action=review

> Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp:215
> +        ASSERT(m_readerThreadNodeMap.get(item.m_isolatedObject->objectID())->refCount() == 2);

can you add a comment why refCount must be two here
Comment 3 Andres Gonzalez 2020-02-14 09:23:22 PST 
Created attachment 390775 [details]
Patch
Comment 4 WebKit Commit Bot 2020-02-14 11:22:38 PST 
Comment on attachment 390775 [details]
Patch

Clearing flags on attachment: 390775

Committed r256630: <https://trac.webkit.org/changeset/256630>
Comment 5 WebKit Commit Bot 2020-02-14 11:22:39 PST 
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2020-02-14 11:23:17 PST 
<rdar://problem/59465611>