| Summary: | [Win][MiniBrowser] Add 'Go Home' menu item and toolbar button | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Fujii Hironori <Hironori.Fujii> | ||||||
| Component: | Tools / Tests | Assignee: | Fujii Hironori <Hironori.Fujii> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | achristensen, bfulgham, don.olmstead, pvollan, ross.kirsling, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Fujii Hironori
2020-02-14 00:05:26 PST
Created attachment 390733 [details]
Patch
Comment on attachment 390733 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=390733&action=review > Tools/MiniBrowser/win/MainWindow.cpp:414 > +void MainWindow::goHome() > +{ > + if (s_commandLineOptions.requestedURL.length()) > + loadURL(s_commandLineOptions.requestedURL); > + else > + loadURL(L"https://www.webkit.org/"); > +} Is there any precedent for using the requested initial URL as a home URL? Comment on attachment 390733 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=390733&action=review >> Tools/MiniBrowser/win/MainWindow.cpp:414 >> +} > > Is there any precedent for using the requested initial URL as a home URL? Good point. There is no precedent. GTK MiniBrowser is using "http://www.webkitgtk.org/" as the fixed home page URL. But, I want to customize home page URL. Adding a command line option doesn't look good. MiniBrowser.exe --homepage <homePageURL> I'm going to add a registry key for home page URL. Mac MiniBrowser has "Set Default URL to Current URL" menu item. (Bug 146780) This seems the best. Created attachment 391143 [details]
Patch
Comment on attachment 391143 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=391143&action=review > Tools/MiniBrowser/win/MainWindow.cpp:-594 > - strPtr[INTERNET_MAX_URL_LENGTH - 1] = 0; I take it this wasn't actually necessary? Comment on attachment 391143 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=391143&action=review Thank you for the review. >> Tools/MiniBrowser/win/MainWindow.cpp:-594 >> - strPtr[INTERNET_MAX_URL_LENGTH - 1] = 0; > > I take it this wasn't actually necessary? Yes, I tested. Comment on attachment 391143 [details] Patch Clearing flags on attachment: 391143 Committed r257024: <https://trac.webkit.org/changeset/257024> All reviewed patches have been landed. Closing bug. |