Bug 207743

Summary: Dynamically generate media-related mach connections when not using the GPU Process
Product: WebKit Reporter: Brent Fulgham <bfulgham>
Component: WebKit2Assignee: Brent Fulgham <bfulgham>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, bfulgham, cdumez, commit-queue, pvollan, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=207850
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

Brent Fulgham
Reported 2020-02-13 21:25:43 PST
As a first step to moving media-related XPC services out of the WebContent process, take the following steps: 1. Remove the permanent XPC service permissions for media-related mach connections. 2. Dynamically create these connections when not using the GPU Process. 3. If the GPU Process is in use, do not open connections -- they should be provided by the GPU Process sandbox.
Attachments
Patch (21.51 KB, patch)
2020-02-13 21:34 PST, Brent Fulgham 		no flags
DetailsFormatted DiffDiff
Patch (22.05 KB, patch)
2020-02-14 12:28 PST, Brent Fulgham 		no flags
DetailsFormatted DiffDiff
Patch (22.11 KB, patch)
2020-02-14 12:40 PST, Brent Fulgham 		no flags
DetailsFormatted DiffDiff
Patch (23.22 KB, patch)
2020-02-14 14:23 PST, Brent Fulgham 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2020-02-13 21:26:06 PST
<rdar://problem/59449750>
Brent Fulgham
Comment 2 2020-02-13 21:34:15 PST
Created attachment 390728 [details] Patch
Brent Fulgham
Comment 3 2020-02-13 21:36:28 PST
Comment on attachment 390728 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=390728&action=review > Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm:377 > + SandboxExtension::createHandleForMachLookup("com.apple.nesessionmanager", WTF::nullopt, managerHandle); I think the multiple WTFMove(handle) calls might do something wrong. @Chris: Does the right thing happen if we pass a moved object to a method taking a reference to be assigned to?
Per Arne Vollan
Comment 4 2020-02-14 11:19:16 PST
Comment on attachment 390728 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=390728&action=review > Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:-126 > - (xpc-service-name "com.apple.audio.toolbox.reporting.service"))) This service does not seem to appear elsewhere in the patch, or am I mistaken? > Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:-212 > - (xpc-service-name "com.apple.MediaPlayer.RemotePlayerService")) Ditto.
Per Arne Vollan
Comment 5 2020-02-14 11:34:58 PST
Comment on attachment 390728 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=390728&action=review > Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm:226 > + "com.apple.coremedia.volumecontroller.xpc", "com.apple.accessibility.mediaaccessibilityd", The service "com.apple.accessibility.mediaaccessibilityd" does not seem to have been removed from the macOS sandbox.
Brent Fulgham
Comment 6 2020-02-14 12:15:53 PST
(In reply to Per Arne Vollan from comment #5) > Comment on attachment 390728 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=390728&action=review > > > Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm:226 > > + "com.apple.coremedia.volumecontroller.xpc", "com.apple.accessibility.mediaaccessibilityd", > > The service "com.apple.accessibility.mediaaccessibilityd" does not seem to > have been removed from the macOS sandbox. Whoops! I'll definitely fix that.
Brent Fulgham
Comment 7 2020-02-14 12:28:13 PST
Created attachment 390795 [details] Patch
Brent Fulgham
Comment 8 2020-02-14 12:40:59 PST
Created attachment 390797 [details] Patch
Per Arne Vollan
Comment 9 2020-02-14 13:10:42 PST
Comment on attachment 390797 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=390797&action=review > Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:855 > + "com.apple.audio.AudioComponentRegistrar" "com.apple.audio.AudioSession" "com.apple.MediaPlayer.RemotePlayerService" > + "com.apple.audio.toolbox.reporting.service" "com.apple.coremedia.admin" "com.apple.coremedia.asset.xpc" I think "com.apple.audio.toolbox.reporting.service" and "com.apple.MediaPlayer.RemotePlayerService" needs to be in a separate extension rule covering xpc-service-name. > Source/WebKit/WebProcess/com.apple.WebProcess.sb.in:852 > + "com.apple.accessibility.mediaaccessibilityd" I think this service should be in a separate extension rule covering xpc-service-name.
Brent Fulgham
Comment 10 2020-02-14 14:23:37 PST
Created attachment 390819 [details] Patch
Brent Fulgham
Comment 11 2020-02-14 14:24:25 PST
Comment on attachment 390797 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=390797&action=review >> Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:855 >> + "com.apple.audio.toolbox.reporting.service" "com.apple.coremedia.admin" "com.apple.coremedia.asset.xpc" > > I think "com.apple.audio.toolbox.reporting.service" and "com.apple.MediaPlayer.RemotePlayerService" needs to be in a separate extension rule covering xpc-service-name. Done. >> Source/WebKit/WebProcess/com.apple.WebProcess.sb.in:852 >> + "com.apple.accessibility.mediaaccessibilityd" > > I think this service should be in a separate extension rule covering xpc-service-name. Done.
Per Arne Vollan
Comment 12 2020-02-14 14:56:46 PST
Comment on attachment 390819 [details] Patch Looks good! R=me.
WebKit Commit Bot
Comment 13 2020-02-14 17:20:23 PST
Comment on attachment 390819 [details] Patch Clearing flags on attachment: 390819 Committed r256660: <https://trac.webkit.org/changeset/256660>
WebKit Commit Bot
Comment 14 2020-02-14 17:20:25 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.