Bug 207729

Summary:

[PlayStation] Make special udis86 C file handling only happen for Visual Studio

Product:

WebKit

Reporter:

Stephan Szabo <stephan.szabo>

Component:

CMake

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

annulen, commit-queue, don.olmstead, ews-watchlist, gyuyoung.kim, keith_miller, mark.lam, msaboff, ryuan.choi, saam, sergio, tzagallo, yoshiaki.jitsukawa

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Stephan Szabo 2020-02-13 16:37:50 PST

For Visual Studio, we have a problem where the c++ standard flag gets set to C files (but Ninja does not add the flag). We now set the source file properties to set the language to CXX which makes Visual Studio building work, however breaks some ninja builds with the same error (now Ninja thinks it's C++ code so adds the flag, but then the compiler tries to compile it as C and fails).

Comment 1 Stephan Szabo 2020-02-13 16:41:16 PST

Created attachment 390703 [details]
Patch

Comment 2 WebKit Commit Bot 2020-02-13 18:24:32 PST

The commit-queue encountered the following flaky tests while processing attachment 390703 [details]:

editing/spelling/spellcheck-attribute.html bug 206178 (authors: g.czajkowski@samsung.com, mark.lam@apple.com, and rniwa@webkit.org)
The commit-queue is continuing to process your patch.

Comment 3 WebKit Commit Bot 2020-02-13 18:25:10 PST

Comment on attachment 390703 [details]
Patch

Clearing flags on attachment: 390703

Committed r256579: <https://trac.webkit.org/changeset/256579>

Comment 4 WebKit Commit Bot 2020-02-13 18:25:12 PST

All reviewed patches have been landed.  Closing bug.