| Summary: | Ensure animations that lose their effect don't schedule an animation update | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Sunny He <sunny_he> | ||||||
| Component: | Animations | Assignee: | Nobody <webkit-unassigned> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | commit-queue, dino, graouts, graouts, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Sunny He
2020-02-13 12:05:58 PST
Created attachment 390675 [details]
Patch
Comment on attachment 390675 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=390675&action=review > Source/WebCore/ChangeLog:3 > + Fix handling of animations which lose their effect I would suggest this bug is renamed "Ensure animations that lose their effect don't schedule an animation update". It's more descriptive of the issue that is fixed. > Source/WebCore/ChangeLog:7 > + You need a description for what your patch does. Something like "An active animation for which the effect is removed may be considered for an upcoming animation resolution. However, WebAnimation::timeToNextTick() expects a valid effect to be available to be able to determine timing. We now check an animation is relevant before calling timeToNextTick() and add an ASSERT() in that function to catch cases where an animation effect might not be available." > Source/WebCore/ChangeLog:8 > + Test: fast/animation/animation-null-effect.html I would file this under LayoutTests/webanimations with other Web Animations tests. The fast/animation directory only contains CSS-based animations tests. Created attachment 390774 [details]
Patch
Comment on attachment 390774 [details] Patch Clearing flags on attachment: 390774 Committed r256623: <https://trac.webkit.org/changeset/256623> All reviewed patches have been landed. Closing bug. |