Bug 207708

Summary: [iOS] Remove access to the "com.apple.lsd.open" mach service from the WebContent process
Product: WebKit Reporter: Brent Fulgham <bfulgham>
Component: WebKit2Assignee: Brent Fulgham <bfulgham>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, pvollan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 205316    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch for landing none

Description Brent Fulgham 2020-02-13 10:13:24 PST 
We now dynamically connect to the 'com.apple.lsd.open' mach service when clients need it, so we no longer need the global permission to use the service.

We should remove it from our sandbox.
Comment 1 Brent Fulgham 2020-02-13 10:13:59 PST 
<rdar://problem/56995506>
Comment 2 Brent Fulgham 2020-02-13 10:21:44 PST 
Created attachment 390665 [details]
Patch
Comment 3 Per Arne Vollan 2020-02-13 11:01:53 PST 
Comment on attachment 390665 [details]
Patch

R=me. There still seems to be some rare cases of access to lsd.open from the WebContent process. Should we hold off landing until we have a backtrace for those accesses?
Comment 4 Brent Fulgham 2020-02-28 10:41:26 PST 
Created attachment 391992 [details]
Patch for landing
Comment 5 WebKit Commit Bot 2020-02-28 11:21:07 PST 
The commit-queue encountered the following flaky tests while processing attachment 391992 [details]:

editing/spelling/spellcheck-async-remove-frame.html bug 158401 (authors: morrita@google.com, rniwa@webkit.org, and tony@chromium.org)
The commit-queue is continuing to process your patch.
Comment 6 WebKit Commit Bot 2020-02-28 11:21:33 PST 
The commit-queue encountered the following flaky tests while processing attachment 391992 [details]:

editing/spelling/spellcheck-input-search-crash.html bug 207995 (authors: arv@chromium.org, g.czajkowski@samsung.com, mark.lam@apple.com, and morrita@google.com)
The commit-queue is continuing to process your patch.
Comment 7 WebKit Commit Bot 2020-02-28 11:57:21 PST 
The commit-queue encountered the following flaky tests while processing attachment 391992 [details]:

http/tests/security/contentSecurityPolicy/report-status-code-zero-when-using-https.html bug 197297 (author: dbates@webkit.org)
The commit-queue is continuing to process your patch.
Comment 8 WebKit Commit Bot 2020-02-28 11:57:54 PST 
Comment on attachment 391992 [details]
Patch for landing

Clearing flags on attachment: 391992

Committed r257650: <https://trac.webkit.org/changeset/257650>
Comment 9 WebKit Commit Bot 2020-02-28 11:57:56 PST 
All reviewed patches have been landed.  Closing bug.