| Summary: | [WPE] Add support for rendering sliders for range elements | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Carlos Garcia Campos <cgarcia> | ||||
| Component: | WPE WebKit | Assignee: | Nobody <webkit-unassigned> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | aperez, bugs-noreply | ||||
| Priority: | P2 | ||||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Carlos Garcia Campos
2020-02-13 06:50:38 PST
Created attachment 390637 [details]
Patch
Comment on attachment 390637 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=390637&action=review > Source/WebCore/platform/wpe/RenderThemeWPE.cpp:368 > + if (part != SliderThumbHorizontalPart && part != SliderThumbVerticalPart) Wouldn't it be enought here to use an assertion instead of a conditional statement? e.g. ASSERT(part == SliderThumbHorizontalPart || part == SliderThumbVerticalPart) Comment on attachment 390637 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=390637&action=review >> Source/WebCore/platform/wpe/RenderThemeWPE.cpp:368 >> + if (part != SliderThumbHorizontalPart && part != SliderThumbVerticalPart) > > Wouldn't it be enought here to use an assertion instead of a conditional > statement? e.g. > > ASSERT(part == SliderThumbHorizontalPart || part == SliderThumbVerticalPart) No, this can be called for other slider thumbs, like the media controls that we render differently. By not setting a size here for them we ensure RenderThemeWPE::paintSliderThumb() is not called fro them, that's why the assert is correct there. Committed r257048: <https://trac.webkit.org/changeset/257048> |