Bug 207691

Summary: [GStreamer][EME] Fix warnings in LOG_DISABLED build
Product: WebKit Reporter: Charlie Turner <cturner>
Component: WebKitGTKAssignee: Charlie Turner <cturner>
Status: RESOLVED FIXED    
Severity: Normal CC: bugs-noreply, calvaris, cgarcia, commit-queue, ews-watchlist, gustavo, menard, pnormand, vjaquez
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description Charlie Turner 2020-02-13 05:34:43 PST 
[GStreamer][EME] Fix warnings in LOG_DISABLED build
Comment 1 Charlie Turner 2020-02-13 05:36:31 PST 
Created attachment 390634 [details]
Patch

Fix warnings with LOG_DISABLED. It would be nice if the LOG macro could arrange for VA_ARGS to be UNUSED_VARIABLES when LOG_DISABLED, but I do not know how to achieve this with preprocessor macros
Comment 2 WebKit Commit Bot 2020-02-13 08:54:50 PST 
Comment on attachment 390634 [details]
Patch

Rejecting attachment 390634 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'validate-changelog', '--check-oops', '--non-interactive', 390634, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

ChangeLog entry in Source/WebCore/ChangeLog contains OOPS!.

Full output: https://webkit-queues.webkit.org/results/13322090
Comment 3 Charlie Turner 2020-02-14 07:15:37 PST 
Created attachment 390762 [details]
Patch
Comment 4 WebKit Commit Bot 2020-02-14 10:05:08 PST 
Comment on attachment 390762 [details]
Patch

Clearing flags on attachment: 390762

Committed r256620: <https://trac.webkit.org/changeset/256620>
Comment 5 WebKit Commit Bot 2020-02-14 10:05:10 PST 
All reviewed patches have been landed.  Closing bug.