Bug 207688

Summary: [WPE] Add support for rendering progress bars
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: WPE WebKitAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: aperez, bugs-noreply
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
aperez: review+
Patch for landing none

Carlos Garcia Campos
Reported 2020-02-13 04:42:19 PST
.
Attachments
Patch (6.00 KB, patch)
2020-02-13 04:43 PST, Carlos Garcia Campos 		aperez: review+
DetailsFormatted DiffDiff
Patch for landing (6.01 KB, patch)
2020-02-18 02:57 PST, Carlos Garcia Campos 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2020-02-13 04:43:54 PST
Created attachment 390630 [details] Patch
Adrian Perez
Comment 2 2020-02-17 15:28:39 PST
Comment on attachment 390630 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=390630&action=review Just one small nit :] > Source/WebCore/platform/wpe/RenderThemeWPE.cpp:263 > + fieldRect.setWidth(std::max<float>(2, fieldRect.width() / progressActivityBlocks)); Isn't two pixels a tad too narrow? Maybe it would make sense to make it slightly wider, I think something around 5 to 6px would be good.
Adrian Perez
Comment 3 2020-02-17 15:30:07 PST
FWIW, which other patches does this depend on? It would be nice to have them listed in the “Depends on” field in the bug =)
Carlos Garcia Campos
Comment 4 2020-02-18 02:56:43 PST
(In reply to Adrian Perez from comment #2) > Comment on attachment 390630 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=390630&action=review > > Just one small nit :] > > > Source/WebCore/platform/wpe/RenderThemeWPE.cpp:263 > > + fieldRect.setWidth(std::max<float>(2, fieldRect.width() / progressActivityBlocks)); > > Isn't two pixels a tad too narrow? Maybe it would make sense to > make it slightly wider, I think something around 5 to 6px would > be good. I don't think so, this is the small bar that moves left -> right -> left for indeterminate progress bars. Those 2 pixels are only used when the width of the progress bar is very small.
Carlos Garcia Campos
Comment 5 2020-02-18 02:57:49 PST
Created attachment 391037 [details] Patch for landing
Carlos Garcia Campos
Comment 6 2020-02-18 03:13:23 PST
Committed r256824: <https://trac.webkit.org/changeset/256824>
Note You need to log in before you can comment on or make changes to this bug.