Bug 207671

Summary: Add release assert for valid registration data in ServiceWorkerRegistration::getOrCreate
Product: WebKit Reporter: youenn fablet <youennf>
Component: Service WorkersAssignee: youenn fablet <youennf>
Status: NEW    
Severity: Normal CC: achristensen, beidson, cdumez, ddkilzer
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch ddkilzer: review+

youenn fablet
Reported 2020-02-12 16:22:01 PST
Add release assert for valid registration data in ServiceWorkerRegistration::getOrCreate
Attachments
Patch (3.09 KB, patch)
2020-02-12 16:24 PST, youenn fablet 		ddkilzer: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2020-02-12 16:24:17 PST
Created attachment 390585 [details] Patch
David Kilzer (:ddkilzer)
Comment 2 2020-04-07 08:16:01 PDT
Comment on attachment 390585 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=390585&action=review > Source/WebCore/workers/service/ServiceWorkerRegistration.cpp:51 > + RELEASE_ASSERT(!data.scopeURL.isNull()); Why not use URL::isValid() instead?
Note You need to log in before you can comment on or make changes to this bug.