Bug 207671

Summary:

Add release assert for valid registration data in ServiceWorkerRegistration::getOrCreate

Product:

WebKit

Reporter:

youenn fablet <youennf>

Component:

Service Workers

Assignee:

youenn fablet <youennf>

Status:

NEW ---

Severity:

Normal

CC:

achristensen, beidson, cdumez, ddkilzer

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	ddkilzer: review+

Description youenn fablet 2020-02-12 16:22:01 PST

Add release assert for valid registration data in ServiceWorkerRegistration::getOrCreate

Comment 1 youenn fablet 2020-02-12 16:24:17 PST

Created attachment 390585 [details]
Patch

Comment 2 David Kilzer (:ddkilzer) 2020-04-07 08:16:01 PDT

Comment on attachment 390585 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=390585&action=review

> Source/WebCore/workers/service/ServiceWorkerRegistration.cpp:51
> +    RELEASE_ASSERT(!data.scopeURL.isNull());

Why not use URL::isValid() instead?