Bug 207670

Summary: [LFC][IFC] Remove LineLayoutContext::m_partialTrailingTextItem
Product: WebKit Reporter: alan <zalan>
Component: Layout and RenderingAssignee: alan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, koivisto, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

alan
Reported 2020-02-12 16:17:22 PST
Now that LineBuilder is not holding a reference to these InlineItems anymore.
Attachments
Patch (3.58 KB, patch)
2020-02-12 16:20 PST, alan 		no flags
DetailsFormatted DiffDiff
Patch (3.58 KB, patch)
2020-02-12 16:50 PST, alan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2020-02-12 16:17:54 PST
<rdar://problem/59405854>
alan
Comment 2 2020-02-12 16:20:46 PST
Created attachment 390584 [details] Patch
Antti Koivisto
Comment 3 2020-02-12 16:36:36 PST
Comment on attachment 390584 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=390584&action=review > Source/WebCore/layout/inlineformatting/LineLayoutContext.h:-85 > Optional<InlineTextItem> m_partialLeadingTextItem; > - Optional<InlineTextItem> m_partialTrailingTextItem; Why not both?
alan
Comment 4 2020-02-12 16:48:33 PST
(In reply to Antti Koivisto from comment #3) > Comment on attachment 390584 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=390584&action=review > > > Source/WebCore/layout/inlineformatting/LineLayoutContext.h:-85 > > Optional<InlineTextItem> m_partialLeadingTextItem; > > - Optional<InlineTextItem> m_partialTrailingTextItem; > > Why not both? The partial leading needs a bit more work. LineBreaker can actually hold onto it as the last wrapping opportunity (this is the rare revert case). I am addressing it in a separate patch.
alan
Comment 5 2020-02-12 16:50:49 PST
Created attachment 390591 [details] Patch
WebKit Commit Bot
Comment 6 2020-02-12 18:47:07 PST
Comment on attachment 390591 [details] Patch Clearing flags on attachment: 390591 Committed r256499: <https://trac.webkit.org/changeset/256499>
WebKit Commit Bot
Comment 7 2020-02-12 18:47:09 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.