| Summary: | results.webkit.org: Link to result archives | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Jonathan Bedard <jbedard> | ||||||
| Component: | Tools / Tests | Assignee: | Jonathan Bedard <jbedard> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | aakash_jain, ap, commit-queue, webkit-bug-importer, zhifei_fang | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Jonathan Bedard
2020-02-12 10:43:43 PST
Created attachment 390543 [details]
Patch
I just have one high level comment, this seems very specific for archives, maybe we should consider a general suite config and make the archive router part of it? It will be easier to expand when we have more configs. (In reply to Zhifei Fang from comment #3) > I just have one high level comment, this seems very specific for archives, > maybe we should consider a general suite config and make the archive router > part of it? It will be easier to expand when we have more configs. It is very specific to archives because nothing else actually requires configurations. I could see configurations about which queues are collapsed by default, but we don't have a mechanism for that yet. unofficially r=me I don't think this will block this patch, we can develop one when we need (In reply to Jonathan Bedard from comment #4) > (In reply to Zhifei Fang from comment #3) > > I just have one high level comment, this seems very specific for archives, > > maybe we should consider a general suite config and make the archive router > > part of it? It will be easier to expand when we have more configs. > > It is very specific to archives because nothing else actually requires > configurations. > > I could see configurations about which queues are collapsed by default, but > we don't have a mechanism for that yet. Comment on attachment 390543 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=390543&action=review rs=me > Tools/ChangeLog:3 > + results.webki.org: Link to result archives typo: webki.org Created attachment 391552 [details]
Patch for landing
Comment on attachment 391552 [details] Patch for landing Clearing flags on attachment: 391552 Committed r257219: <https://trac.webkit.org/changeset/257219> All reviewed patches have been landed. Closing bug. |