Bug 207598

Summary: Allow use of proxies in MiniBrowser
Product: WebKit Reporter: Ben Nham <nham>
Component: Page LoadingAssignee: Ben Nham <nham>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, beidson, commit-queue, koivisto, nham, sam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Ben Nham
Reported 2020-02-11 16:14:37 PST
For testing purposes, we allow Safari to use a custom HTTP/HTTPS proxy passed through command line arguments. MiniBrowser should also be able to do this.
Attachments
Patch (6.48 KB, patch)
2020-02-11 16:18 PST, Ben Nham 		no flags
DetailsFormatted DiffDiff
Patch (6.86 KB, patch)
2020-02-11 20:01 PST, Ben Nham 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2020-02-11 16:15:15 PST
<rdar://problem/59368527>
Ben Nham
Comment 2 2020-02-11 16:18:19 PST
Created attachment 390458 [details] Patch
Ben Nham
Comment 3 2020-02-11 20:01:48 PST
Created attachment 390486 [details] Patch
WebKit Commit Bot
Comment 4 2020-02-13 11:47:35 PST
Comment on attachment 390486 [details] Patch Clearing flags on attachment: 390486 Committed r256530: <https://trac.webkit.org/changeset/256530>
WebKit Commit Bot
Comment 5 2020-02-13 11:47:36 PST
All reviewed patches have been landed. Closing bug.
Alex Christensen
Comment 6 2020-02-13 15:32:10 PST
Comment on attachment 390486 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=390486&action=review > Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm:386 > parameters.defaultDataStoreParameters.networkSessionParameters.httpProxy = URL(URL(), [defaults stringForKey:(NSString *)WebKit2HTTPProxyDefaultsKey]); This patch is good, but we should be pushing Safari and MiniBrowser towards using SPI when they want proxies rather than checking in defaults ourselves.
Sam Weinig
Comment 7 2020-02-19 18:29:30 PST
Why are we special casing these apps? Seems like what a preference they enable or entitlements are for if we want to limit this for some reason.
Note You need to log in before you can comment on or make changes to this bug.