Bug 207576

Summary:

sampling-profiler-wasm-name-section should run for more iterations

Product:

WebKit

Reporter:

Jonathan Bedard <jbedard>

Component:

JavaScriptCore

Assignee:

Saam Barati <saam>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

jbedard, mark.lam, saam, webkit-bug-importer, ysuzuki

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
patch	none

Description Jonathan Bedard 2020-02-11 12:56:55 PST

This test flakily fails in automation:

https://results.webkit.org/?suite=javascriptcore-tests&test=stress%2Fsampling-profiler-wasm-name-section.js.default

Added by Yusuke Suzuki in https://trac.webkit.org/changeset/248187/webkit.

Comment 1 Radar WebKit Bug Importer 2020-02-13 11:34:41 PST

<rdar://problem/59431250>

Comment 2 Alexey Proskuryakov 2020-02-13 11:38:42 PST

stress/sampling-profiler-wasm-name-section.js.default: {
stress/sampling-profiler-wasm-name-section.js.default:   "name": "<root>",
stress/sampling-profiler-wasm-name-section.js.default:   "children": {
stress/sampling-profiler-wasm-name-section.js.default:     "(program)": {
stress/sampling-profiler-wasm-name-section.js.default:       "name": "(program)",
stress/sampling-profiler-wasm-name-section.js.default:       "children": {
stress/sampling-profiler-wasm-name-section.js.default:         "runTest": {
stress/sampling-profiler-wasm-name-section.js.default:           "name": "runTest",
stress/sampling-profiler-wasm-name-section.js.default:           "children": {
stress/sampling-profiler-wasm-name-section.js.default:             "wasmEntry": {
stress/sampling-profiler-wasm-name-section.js.default:               "name": "wasmEntry",
stress/sampling-profiler-wasm-name-section.js.default:               "children": {
stress/sampling-profiler-wasm-name-section.js.default:                 "(unknown)": {
stress/sampling-profiler-wasm-name-section.js.default:                   "name": "(unknown)",
stress/sampling-profiler-wasm-name-section.js.default:                   "children": {
stress/sampling-profiler-wasm-name-section.js.default:                     "<?>.wasm-function[_parrot]": {
stress/sampling-profiler-wasm-name-section.js.default:                       "name": "<?>.wasm-function[_parrot]",
stress/sampling-profiler-wasm-name-section.js.default:                       "children": {
stress/sampling-profiler-wasm-name-section.js.default:                         "<?>.wasm-function[_spam]": {
stress/sampling-profiler-wasm-name-section.js.default:                           "name": "<?>.wasm-function[_spam]",
stress/sampling-profiler-wasm-name-section.js.default:                           "children": {
stress/sampling-profiler-wasm-name-section.js.default:                             "<?>.wasm-function[_bacon]": {
stress/sampling-profiler-wasm-name-section.js.default:                               "name": "<?>.wasm-function[_bacon]",
stress/sampling-profiler-wasm-name-section.js.default:                               "children": {
stress/sampling-profiler-wasm-name-section.js.default:                                 "<?>.wasm-function[_eggs]": {
stress/sampling-profiler-wasm-name-section.js.default:                                   "name": "<?>.wasm-function[_eggs]",
stress/sampling-profiler-wasm-name-section.js.default:                                   "children": {
stress/sampling-profiler-wasm-name-section.js.default:                                     "(unknown)": {
stress/sampling-profiler-wasm-name-section.js.default:                                       "name": "(unknown)",
stress/sampling-profiler-wasm-name-section.js.default:                                       "children": {
stress/sampling-profiler-wasm-name-section.js.default:                                         "_silly": {
stress/sampling-profiler-wasm-name-section.js.default:                                           "name": "_silly",
stress/sampling-profiler-wasm-name-section.js.default:                                           "children": {}
stress/sampling-profiler-wasm-name-section.js.default:                                         }
stress/sampling-profiler-wasm-name-section.js.default:                                       }
stress/sampling-profiler-wasm-name-section.js.default:                                     }
stress/sampling-profiler-wasm-name-section.js.default:                                   }
stress/sampling-profiler-wasm-name-section.js.default:                                 }
stress/sampling-profiler-wasm-name-section.js.default:                               }
stress/sampling-profiler-wasm-name-section.js.default:                             }
stress/sampling-profiler-wasm-name-section.js.default:                           }
stress/sampling-profiler-wasm-name-section.js.default:                         }
stress/sampling-profiler-wasm-name-section.js.default:                       }
stress/sampling-profiler-wasm-name-section.js.default:                     }
stress/sampling-profiler-wasm-name-section.js.default:                   }
stress/sampling-profiler-wasm-name-section.js.default:                 },
stress/sampling-profiler-wasm-name-section.js.default:                 "get exports": {
stress/sampling-profiler-wasm-name-section.js.default:                   "name": "get exports",
stress/sampling-profiler-wasm-name-section.js.default:                   "children": {}
stress/sampling-profiler-wasm-name-section.js.default:                 },
stress/sampling-profiler-wasm-name-section.js.default:                 "_parrot": {
stress/sampling-profiler-wasm-name-section.js.default:                   "name": "_parrot",
stress/sampling-profiler-wasm-name-section.js.default:                   "children": {}
stress/sampling-profiler-wasm-name-section.js.default:                 }
stress/sampling-profiler-wasm-name-section.js.default:               }
stress/sampling-profiler-wasm-name-section.js.default:             },
stress/sampling-profiler-wasm-name-section.js.default:             "updateCallingContextTree": {
stress/sampling-profiler-wasm-name-section.js.default:               "name": "updateCallingContextTree",
stress/sampling-profiler-wasm-name-section.js.default:               "children": {
stress/sampling-profiler-wasm-name-section.js.default:                 "next": {
stress/sampling-profiler-wasm-name-section.js.default:                   "name": "next",
stress/sampling-profiler-wasm-name-section.js.default:                   "children": {
stress/sampling-profiler-wasm-name-section.js.default:                     "arrayIteratorNextHelper": {
stress/sampling-profiler-wasm-name-section.js.default:                       "name": "arrayIteratorNextHelper",
stress/sampling-profiler-wasm-name-section.js.default:                       "children": {}
stress/sampling-profiler-wasm-name-section.js.default:                     }
stress/sampling-profiler-wasm-name-section.js.default:                   }
stress/sampling-profiler-wasm-name-section.js.default:                 },
stress/sampling-profiler-wasm-name-section.js.default:                 "samplingProfilerStackTraces": {
stress/sampling-profiler-wasm-name-section.js.default:                   "name": "samplingProfilerStackTraces",
stress/sampling-profiler-wasm-name-section.js.default:                   "children": {}
stress/sampling-profiler-wasm-name-section.js.default:                 },
stress/sampling-profiler-wasm-name-section.js.default:                 "makeChildIfNeeded": {
stress/sampling-profiler-wasm-name-section.js.default:                   "name": "makeChildIfNeeded",
stress/sampling-profiler-wasm-name-section.js.default:                   "children": {}
stress/sampling-profiler-wasm-name-section.js.default:                 }
stress/sampling-profiler-wasm-name-section.js.default:               }
stress/sampling-profiler-wasm-name-section.js.default:             },
stress/sampling-profiler-wasm-name-section.js.default:             "doesTreeHaveStackTrace": {
stress/sampling-profiler-wasm-name-section.js.default:               "name": "doesTreeHaveStackTrace",
stress/sampling-profiler-wasm-name-section.js.default:               "children": {
stress/sampling-profiler-wasm-name-section.js.default:                 "samplingProfilerStackTraces": {
stress/sampling-profiler-wasm-name-section.js.default:                   "name": "samplingProfilerStackTraces",
stress/sampling-profiler-wasm-name-section.js.default:                   "children": {}
stress/sampling-profiler-wasm-name-section.js.default:                 }
stress/sampling-profiler-wasm-name-section.js.default:               }
stress/sampling-profiler-wasm-name-section.js.default:             },
stress/sampling-profiler-wasm-name-section.js.default:             "now": {
stress/sampling-profiler-wasm-name-section.js.default:               "name": "now",
stress/sampling-profiler-wasm-name-section.js.default:               "children": {}
stress/sampling-profiler-wasm-name-section.js.default:             }
stress/sampling-profiler-wasm-name-section.js.default:           }
stress/sampling-profiler-wasm-name-section.js.default:         }
stress/sampling-profiler-wasm-name-section.js.default:       }
stress/sampling-profiler-wasm-name-section.js.default:     }
stress/sampling-profiler-wasm-name-section.js.default:   }
stress/sampling-profiler-wasm-name-section.js.default: }
stress/sampling-profiler-wasm-name-section.js.default: failing on 6 : wasm-stub
stress/sampling-profiler-wasm-name-section.js.default: Exception: Error: Bad stack trace
stress/sampling-profiler-wasm-name-section.js.default: runTest@./sampling-profiler/samplingProfiler.js:85:20
stress/sampling-profiler-wasm-name-section.js.default: global code@sampling-profiler-wasm-name-section.js:72:12
stress/sampling-profiler-wasm-name-section.js.default: ERROR: Unexpected exit code: 3
FAIL: stress/sampling-profiler-wasm-name-section.js.default
Running stress/sparse_splice.js.no-cjit-validate-phases

Comment 3 Saam Barati 2020-06-18 15:24:27 PDT

*** Bug 213358 has been marked as a duplicate of this bug. ***

Comment 4 Saam Barati 2020-06-18 15:33:46 PDT

Created attachment 402243 [details]
patch

Comment 5 EWS 2020-06-18 15:58:13 PDT

Committed r263240: <https://trac.webkit.org/changeset/263240>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 402243 [details].