| Summary: | [ews] add SetBuildSummary step for Windows EWS | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Aakash Jain <aakash_jain> | ||||||
| Component: | Tools / Tests | Assignee: | Aakash Jain <aakash_jain> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | jbedard, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | Other | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Aakash Jain
2020-02-11 09:10:26 PST
Created attachment 390373 [details]
Patch
Created attachment 390374 [details]
Patch
Comment on attachment 390374 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=390374&action=review > Tools/ChangeLog:10 > + (GTKBuildAndTestFactory.__init__): Adding it for GTK too? This change would fix the build summary for builds like this: https://ews-build.webkit.org/#/builders/10/builds/7056 (In reply to Jonathan Bedard from comment #3) > Adding it for GTK too? Yes, because GTK factory also have the same layout-test step which was modified in Bug 207492. Although that code path is not used currently by any GTK factory. Committed r256729: <https://trac.webkit.org/changeset/256729> |